chore: update client spec to new feature-removed delta event #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sighphyre
added a commit
that referenced
this pull request
Jul 22, 2025
* fix: add test cases for edge cases for constraints related to Unleash/unleash#640 * Create node.js.yml * fix: remove travis * 3.3.1 * Disabled toggles should produce a disabled variant * feat: add specifications for custom stickiness * Update specifications/12-custom-stickiness.json Co-authored-by: Ivan Lee <[email protected]> * Update specifications/12-custom-stickiness.json Co-authored-by: Ivan Lee <[email protected]> * fix: follow schema * 4.0.0 * Add renovate.json * chore(deps): update dependency chalk to v4 * chore(deps): pin dependencies * chore(deps): update actions/setup-node action to v2 * chore: rename master -> main in badge links. * chore: update workflow after rename master -> main * fix: switch to yarn * fix: upgrade joi to v17.6.0 * Fix api typo * feat: add specifications for new operators * fix: more testcases for operators * fix: more operators * fix: more operators * fix: constraint value is string * chore: add more semver and number tests * fix: correct test cases for semver operator * refactor: update README specs list * fix: remove .json suffix from spec name * feat: extend tests for timezones, invalid constraints and broken semvers * chore(deps): update actions/checkout action to v3 * chore(deps): update actions/setup-node action to v3 (#27) Co-authored-by: Renovate Bot <[email protected]> * v4.1.0 * docs: fix links * meta: add 'new items to project board' workflow This change adds a workflow to automatically add new issues and PRs to a specified project board for easier watching * feat: Add tests for global segment handling * fix: Patch spelling mistake in project description * Update test suite name for global constraints * meta: add external PRs to project board The `pull_request` hook runs in the context of the proposed changes. That means that for forks, this action won't have access to the required secrets for it to complete. As such, PRs from outside contributors won't work correctly. The `pull_request_target` hook, however, runs in the context of the target branch, and thus has all the permissions it needs. The [github docs for this hook](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target) also indicate that this is the way to go: > This event allows your workflow to do things like label or comment on pull requests from forks. Avoid using this event if you need to build or run code from the pull request. * feat: extend global segment tests and fix schema * fix: make tests actually fail when validation of schema fails * 4.2.0 * Updates list of specifications. Since we've added a new one, this PR updates the output for index.json to also display 15-global-constraints.json * fix: add cases for missing contextFields together with IN (#37) * chore: release pipeline (#35) * 4.2.1 * meta: add stale bot config (reference unleash/.github) This change adds a stale bot configuration with a reference to the [org-wide Unleash configuration](https://github.com/Unleash/.github/blob/main/.github/stale.yml). ## About the change We're adding stale bot as a way to help us manage issues that don't see any activity. When that happens, it's usually because we don't have further resources to work on something or because we're missing information. These issues often go forgotten and end up lying around open. This is an attempt to get around that. The config file contains the details for how long the bot waits before touching an issue and then how much longer before it closes it if no further activity occurs. (Currently set to 30 and 10 days respectively.) ## Keeping issues open If there are long-standing issues that should _not_ be closed or marked as stale, you can label it with one of the `exemptLabels` in the stale config file (for instance: `pinned`). That'll keep stale bot from touching the issue at all. ## For maintainers We know there are differing views on whether stale bots are healthy or not, and we would not want to impose a bot on a repo that we do not control. So if you're not sure this is a good idea (or if you're sure that it _isn't_), let us know, and we'll have a discussion. If we come to the conclusion that it's not the right decision (for whatever reason), then we're happy to leave the bot out. Further, if you're happy to accept the stale bot, but don't like the org-wide configuration, then we can also override parts or all of the config to make it fit better with this repo. * fix: set segment id to 404 * chore(deps): update dependency joi to v17.6.1 (#40) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency joi to v17.6.4 (#41) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency joi to v17.7.0 (#43) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * If variants are empty we expect FT to be disabled (#45) * fix: this patches the strEndsWith test case (#47) * fix: this patches the strEndsWith test case to correctly check that the string ends with rather than allowing the inverse * Feat/case insensitive in operators (#48) * Create test for case insensitive In operators * update index * add special characters, more tests, better descriptions * better toggle names * chore(deps): update dependency joi to v17.8.1 (#49) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Revert "Feat/case insensitive in operators (#48)" (#53) This reverts commit 8ec0b20. * feat: strategy variant (#55) * fix: trim duplicate variant strategy property (#56) * feat: add empty variant test when strategy does not match/feature is disabled (#57) * test: add missing check for multiple strategies last matching (#59) * feat: variant with type number in the payload (#61) * feat: variant with type number in the payload * Update specifications/08-variants.json Co-authored-by: Simon Hornby <[email protected]> * Update specifications/08-variants.json Co-authored-by: Simon Hornby <[email protected]> * feat: variant with type number in the payload --------- Co-authored-by: Simon Hornby <[email protected]> * 4.3.4 (#62) * Revert "4.3.4 (#62)" This reverts commit 73870fa. * 4.4.0 * feat: dependent features (#63) * fix: adds a test case for when strategy variants are empty but base variants are present (#64) * fix: add test case for dependency asking for disabled variant (#65) * fix: add test case for dependency asking for disabled variant This change adds a new test case to the dependent features spec: If a child depends on a parent's variant, but expects that variant to be "disabled", the child should nonetheless be disabled if the parent is disabled. In other words, the only way for that to be true is if the parent has a named variant called "disabled". This covers a hole in the spec where a child could be enabled even if its parent was disabled, as long as the child depended on the parent's "disabled" variant. * fix: add missing comma * Chore: bump version in package.json (#66) * fix: New variant distribution seed needs new id to still pick same variant (#68) * 5.0.0 * chore(deps): update actions/setup-node action to v4 (#67) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: Update variant tests to expect the new seed to be used for selecting variant (#69) * 5.0.1 * Fix: test is testing payload, not variant name * 5.0.2 * chore: update node version (#71) * chore(deps): update dependency joi to v17.11.0 (#58) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat: add feature_enabled property to variants (#70) * docs: Add feature_enabled flag to README (#72) * chore: update version (#73) * fix: add case for explicitly enabled parent (#75) * fix: add case for inverted IN and NOT_IN (#78) * chore: update version to 5.1.2 (#79) * chore: update to 5.1.3 (#80) * chore(deps): update dependency joi to v17.11.1 (#81) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency joi to v17.12.0 (#82) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * test: add missing test for custom stickiness only on strategy and not on variant (#83) * chore(deps): update dependency joi to v17.12.1 (#84) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * docs: fix README.md typo (#85) * chore(deps): update dependency joi to v17.12.2 (#86) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency joi to v17.13.1 (#87) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * task: add test case for case insensitive starts with (#88) * 5.1.5 * fix: make test names unique (#90) fixes: #89 * 5.1.6 * chore(deps): update dependency joi to v17.13.3 (#91) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: combine a variant test with a segment contraint (#92) * v5.1.7 * chore: add UTF-8 flag names test (#94) * chore: v5.1.9 (#95) * feat: delta api spec tests (#96) * feat: spec tests for hydration event * feat: add support for deltas api in the tests --------- Co-authored-by: FredrikOseberg <[email protected]> * chore: update client spec to new feature-removed delta event (#97) * chore: update client spec to new feature-removed delta event * v5.2.2 (#98) * chore: update docs about release process (#99) * chore: update docs about release process * pass spec test 11, 13 and 14 * revert changing 14 --------- Co-authored-by: Ivar Conradi Østhus <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: Ivan Lee <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Thomas Heartman <[email protected]> Co-authored-by: Elan Ruusamäe <[email protected]> Co-authored-by: Christopher Kolstad <[email protected]> Co-authored-by: Christopher Kolstad <[email protected]> Co-authored-by: olav <[email protected]> Co-authored-by: sighphyre <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Gastón Fournier <[email protected]> Co-authored-by: Thomas Heartman <[email protected]> Co-authored-by: Fredrik Oseberg <[email protected]> Co-authored-by: Gastón Fournier <[email protected]> Co-authored-by: andreas-unleash <[email protected]> Co-authored-by: Mateusz Kwasniewski <[email protected]> Co-authored-by: Jaanus Sellin <[email protected]> Co-authored-by: Ivar Conradi Østhus <[email protected]> Co-authored-by: Christopher Kolstad <[email protected]> Co-authored-by: Tymoteusz Czech <[email protected]> Co-authored-by: Eduardo Khattab <[email protected]> Co-authored-by: Gastón Fournier <[email protected]> Co-authored-by: Nuno Góis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.