Skip to content

Ninalopatina add file type support #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Ninalopatina add file type support #2

wants to merge 2 commits into from

Conversation

@ninalopatina
Copy link

Description

Adds support for:
.bmp
.doc
.heic
.jpeg
.msg
.odt
.org
.p7s
.ppt
.rst
.rtf
.tiff
.xls

How Has This Been Tested?

I ran this locally and successfully parsed my excel doc from before, as well as a table in a .jpeg

Accepted Risk

still have a bug in processing sheets that I'm unclear of the origin of

Related Issue(s)

[If applicable, link to the issue(s) this PR addresses]

Checklist:

  • [x ] All of the automated tests pass
  • [ x] All PR comments are addressed and marked resolved
  • [x ] If there are migrations, they have been rebased to latest main
  • [x ] If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
    ^ only docker
  • [x ] If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • [x ] Docker images build and basic functionalities work
  • [ x] Author has done a final read through of the PR right before merge

@ninalopatina ninalopatina self-assigned this Aug 23, 2024
jasonbot
jasonbot reviewed Aug 23, 2024
View reviewed changes
backend/danswer/connectors/google_drive/connector.py
from danswer.utils.batching import batch_generator
from danswer.utils.logger import setup_logger

from danswer.file_processing.extract_file_text import read_any_file
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to reorder this import?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no but its fine wherever

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MKhalusova MKhalusova MKhalusova approved these changes

+2 more reviewers

@jasonbot jasonbot jasonbot approved these changes

@treighton treighton treighton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ninalopatina ninalopatina

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ninalopatina @jasonbot @MKhalusova @treighton