Refactor Clean Dir Approach #804
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AbdurrehmanSubhani
commented
Dec 21, 2024
AbdurrehmanSubhani
commented
- remove "force" flag keeping only forceNoConfirm, better DX to always prompt user if directory not empty instead of throwing exceptions
- prompt user if the directory is not empty to delete contents
…irectory is not empty to delete contents
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
avaer
reviewed
Dec 22, 2024
| const source = args.source; | ||
| const features = typeof args.feature === 'string' ? JSON.parse(args.feature) : (args.feature || {}); | ||
| const yes = args.yes; | ||
| const force = !!args.force; |
Contributor
There was a problem hiding this comment.
If this flag is no longer needed, we can remove the option from the cli.
Contributor
Author
There was a problem hiding this comment.
Ah yes overlooked, removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.