rm transfers from start stations; fixes #88

UrbanAnalyst · Aug 17, 2022 · daab5e3 · daab5e3
1 parent 2efeee4
commit daab5e3
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: gtfsrouter
 Title: Routing with GTFS (General Transit Feed Specification) Data
-Version: 0.0.5.099
+Version: 0.0.5.100
 Authors@R: c(
     person("Mark", "Padgham", , "[email protected]", role = c("aut", "cre")),
     person("Marcin", "Stepniak", , "[email protected]", role = "aut",

diff --git a/codemeta.json b/codemeta.json
@@ -7,7 +7,7 @@
   "codeRepository": "https://github.com/ATFutures/gtfs-router",
   "issueTracker": "https://github.com/ATFutures/gtfs-router/issues",
   "license": "https://spdx.org/licenses/GPL-3.0",
-  "version": "0.0.5.099",
+  "version": "0.0.5.100",
   "programmingLanguage": {
     "@type": "ComputerLanguage",
     "name": "R",

diff --git a/src/traveltimes.cpp b/src/traveltimes.cpp
@@ -24,8 +24,12 @@ void iso::trace_forward_traveltimes (
         if (departure_time [i] < start_time_min)
             continue; // # nocov - these lines already removed in R fn.
 
-        const bool is_start_stn = iso::is_start_stn (start_stations_set,
-                departure_station [i]);
+        // connections can also arrive at one of the departure stations, and
+        // these are also flagged as start stations to prevent transfers being
+        // constructed from the arrival/start station.
+        const bool is_start_stn =
+            iso::is_start_stn (start_stations_set, departure_station [i]) ||
+            iso::is_start_stn (start_stations_set, arrival_station [i]);
 
         if (is_start_stn && departure_time [i] > start_time_max)
             continue;