Flat app icon #1111
Merged
Flat app icon #1111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also rename round PNGs for consistency and to allow using them inside the app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use adaptive icon wherever the app icon is used inside the app, plus in the account system settings.
Based on better understanding of resource IDs, also remove duplicate round icon resource.
I vaguely remember using the adaptive icon caused issues on some devices (maybe because previously it was a PNG combined with an SVG?), so roll out with care. Did not observe any issues when testing on Android 5, 8, 15 or 16.
The foreground is using a stroke that's kind of pointless. But it was easier to copy the monochrome icon than re-create the SVG to exactly match using a fill instead.Removed it, makes not much difference.