Cloud: correctly apply skipped episode state when re-adding a show #1112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UweTrottmann
changed the title
UweTrottmann
force-pushed
the
cloud-fix-skipped-not-downloaded
branch
from
ff80303 to
3184d0f
Compare
UweTrottmann
force-pushed
the
cloud-fix-skipped-not-downloaded
branch
from
3184d0f to
c40bb77
Compare
As a side-effect correctly set a value for plays for skipped episodes when downloading flags for newly added shows.
UweTrottmann
force-pushed
the
cloud-fix-skipped-not-downloaded
branch
from
c40bb77 to
ec190c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When introducing plays a regression was introduced where the skipped status would not get applied to episodes when adding a show and downloading episode state from Cloud.
The database update method required plays to be not null, but for skipped episodes plays were not explicitly set to
0but left atnull.This resolves this issue and refactors the build and apply methods to facilitate testing. This adds tests for common cases, also when downloading changes ("syncing").