Skip to content

Conversation

@SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Apr 22, 2025

  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи
  • Release notes

Описание

Добавляем возможность пробросить кастомный цвет в ContentBadge

image

Release notes

Улучшения

  • ContentBadge: в appearance можно пробросить любой цвет

@SevereCloud SevereCloud requested a review from a team as a code owner April 22, 2025 13:08
@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2025

size-limit report 📦

Path Size
JS 411.28 KB (+0.05% 🔺)
JS (gzip) 122.06 KB (+0.09% 🔺)
JS (brotli) 99.97 KB (+0.11% 🔺)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 348.74 KB (-0.06% 🔽)
CSS (gzip) 43.19 KB (-0.06% 🔽)
CSS (brotli) 34.49 KB (+0.02% 🔺)

@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2025

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://vkui-screenshot.hb.bizmrg.com/pull/8507/816fd8ffd25d4d4443a5163c4f6fc3d835635ac4/pkg/@vkontakte/vkui/_pkg.tgz

Commit 816fd8f

@codecov
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.

Project coverage is 95.80%. Comparing base (2ab8533) to head (816fd8f).
Report is 26 commits behind head on master.

Files with missing lines Patch % Lines
.../vkui/src/components/ContentBadge/ContentBadge.tsx 73.68% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8507      +/-   ##
==========================================
+ Coverage   95.60%   95.80%   +0.19%     
==========================================
  Files         414      414              
  Lines       11824    11906      +82     
  Branches     3917     3942      +25     
==========================================
+ Hits        11304    11406     +102     
+ Misses        520      500      -20     
Flag Coverage Δ
unittests 95.80% <73.68%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SevereCloud SevereCloud added this to VKUI Apr 23, 2025
@SevereCloud SevereCloud moved this to ⛔️ Blocked in VKUI Apr 23, 2025
@SevereCloud SevereCloud self-assigned this Apr 23, 2025
Comment on lines +59 to +60
if (appearance.startsWith('var(--')) {
return appearance;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Довольно щедро. Не станет ли это проблемой?
Используя такое апи, можно задать "слишком" кастомный цвет, например var(--vkui--color_field_border_alpha) или даже var(--does-not-exist, rebeccapurple).
Может быть, просто дополним недостающие appearance, которые сейчас используются в продукте, и не будем делать полный кастом?

@vkcom-publisher vkcom-publisher added the pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности label May 2, 2025
@vkcom-publisher
Copy link
Contributor

PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно.

@github-project-automation github-project-automation bot moved this from ⛔️ Blocked to ✅ Done in VKUI May 10, 2025
@inomdzhon inomdzhon deleted the SevereCloud/feat/ContentBadge/support-custom-color branch December 12, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants