Skip to content

fix(Clickable): rm RealClickable #8749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 16, 2025

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Jul 14, 2025


  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи
  • Release notes

Описание

Удаляем компонент RealClickable, переносим логику в один компонент

В модалках фокустрап ловил новую дом ноду и фокусировался на нее. Поэтому мы делаем кнопку всегда кликабельной

Release notes

Исправления

  • Переключение свойства disabled в кликабельных компонентах больше не обновляет dom ноды

@SevereCloud SevereCloud requested a review from a team as a code owner July 14, 2025 14:20
@github-actions github-actions bot added the ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Jul 14, 2025
Copy link
Contributor

github-actions bot commented Jul 14, 2025

size-limit report 📦

Path Size
JS 415.13 KB (+0.05% 🔺)
JS (gzip) 123.65 KB (+0.04% 🔺)
JS (brotli) 101.62 KB (+0.17% 🔺)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 349.95 KB (0%)
CSS (gzip) 43.4 KB (0%)
CSS (brotli) 34.62 KB (0%)

Copy link
Contributor

github-actions bot commented Jul 14, 2025

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Jul 14, 2025

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://vkui-screenshot.hb.bizmrg.com/pull/8749/6f09a7bb59738e025de96c05c1f435581f7923f0/pkg/@vkontakte/vkui/_pkg.tgz

Commit 6f09a7b

Copy link

codecov bot commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.96%. Comparing base (a014c9f) to head (6f09a7b).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8749      +/-   ##
==========================================
- Coverage   95.96%   95.96%   -0.01%     
==========================================
  Files         419      418       -1     
  Lines       12134    12133       -1     
  Branches     4033     4033              
==========================================
- Hits        11644    11643       -1     
  Misses        490      490              
Flag Coverage Δ
unittests 95.96% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SevereCloud SevereCloud merged commit 4ead24a into master Jul 16, 2025
29 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/fix/Clickable/rm-RealClickable branch July 16, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:cherry-pick:patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Переключение disabled у Tappable полностью ререндерит компонент
3 participants