Skip to content

chore(build): PyInstallerv6エンジンに変更 #2711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025

Conversation

sabonerune
Copy link
Contributor

内容

PyInstaller更新により正常に動作するか確認用のPRです。
特にmacOSのDMG版が正常に動作するか確認する必要があります。

関連 Issue

ref VOICEVOX/voicevox_engine#1667
VOICEVOX/voicevox_engine#1667 (comment)

その他

多分変更するのはここだけでいいはず。

@sabonerune sabonerune requested a review from a team as a code owner July 14, 2025 00:47
@sabonerune sabonerune requested review from Hiroshiba and removed request for a team July 14, 2025 00:47
@voicevox-preview-pages
Copy link

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:48189bf

@Hiroshiba Hiroshiba changed the title feat: PyInstallerv6エンジンに変更 chore(build): PyInstallerv6エンジンに変更 Jul 14, 2025
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

マージしちゃって、実際にmacで動くか確かめるのが良さそう?

@Hiroshiba Hiroshiba requested a review from sevenc-nanashi July 14, 2025 00:54
Copy link
Member

@sevenc-nanashi sevenc-nanashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

特に問題なさそう。

@Hiroshiba
Copy link
Member

Hiroshiba commented Jul 14, 2025

良さそうなら最後の人がマージすると効率良さそう?
マージします!

@Hiroshiba Hiroshiba enabled auto-merge July 14, 2025 02:16
@Hiroshiba Hiroshiba added this pull request to the merge queue Jul 14, 2025
Merged via the queue into VOICEVOX:main with commit ecf7064 Jul 14, 2025
11 checks passed
@sabonerune sabonerune deleted the bld/pyinstaller-v6 branch July 14, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants