Closed
Conversation
emesare
reviewed
Jan 13, 2025
Member
There was a problem hiding this comment.
I find the before to be more readable
Contributor
Author
There was a problem hiding this comment.
yeah, it would be best if the definition of BNInstructionInfo was the following instead:
pub struct BNInstructionInfo {
pub length: usize,
pub branchCount: usize,
pub archTransitionByTargetAddr: bool,
pub delaySlots: u8,
pub branchInfo: [BNBranchInfo; 3usize],
}
pub struct BNBranchInfo {
pub branchType: BNBranchType,
pub branchTarget: u64,
#[doc = " If null, same architecture as instruction"]
pub branchArch: *mut BNArchitecture,
}Then we could iterate over all the branch info at once instead of by-index. This would require changing the C++ definition though.
emesare
reviewed
Jan 13, 2025
emesare
reviewed
Jan 13, 2025
Member
|
Merged with 3ea9c4e thank you! I also went ahead and added clippy to the CI, it should only warn however. Mostly just good for visibility in PR's! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran
cargo clippywith default lints. A few small cleanups included as well.