Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ checkBalanceOf #1397

Merged
merged 2 commits into from
Apr 2, 2025
Merged

✨ checkBalanceOf #1397

merged 2 commits into from
Apr 2, 2025

Conversation

Vectorized
Copy link
Owner

Description

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge fmt?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

Copy link

github-actions bot commented Apr 2, 2025

Gas Snapshot Comparison Report

Generated at commit : 959b7ea, Compared to commit : 115220c

Contract Name Test Name Main Gas PR Gas Diff
SafeTransferLibTest testApproveWithNonContractReverts() 6879 6945 66
testApproveWithRetryWithNonContractReverts() 7356 7312 -44
testApproveWithReturnsFalseReverts() 10274 10252 -22
testApproveWithReturnsTooLittleReverts() 10156 10201 45
testApproveWithReturnsTooMuch() 32913 32891 -22
testApproveWithRevertingReverts() 10202 10180 -22
testForceTransferETHToGriever() 1511560 1511876 316
testPermit2() 90435 90413 -22
testPermit2AnythingWithNonContractReverts() 125148 125193 45
testSimplePermit2AndPermit2TransferFrom() 1145633 1146083 450
testSimplePermit2AndPermit2TransferFromGas() 141552 141639 87
testTotalSupplyQuery() 27469 27403 -66
testTransferAllFromWithStandardERC20() 33862 33907 45
testTransferAllWithStandardERC20() 31024 31002 -22
testTransferETH() 34644 34600 -44
testTransferETHToContractWithoutFallbackReverts() 10894 10828 -66
testTransferFromWithMissingReturn() 631670 1322266 690596
testTransferFromWithNonContractReverts() 8097 8118 21
testTransferFromWithReturnsFalseReverts() 598118 603799 5681
testTransferFromWithReturnsTooLittleReverts() 598061 603742 5681
testTransferFromWithReturnsTooMuch() 632664 638324 5660
testTransferFromWithRevertingReverts() 591004 596686 5682
testTransferFromWithStandardERC20() 631122 636715 5593
testTransferWithMissingReturn() 618755 624135 5380
testTransferWithNonContractReverts() 6885 6908 23
testTransferWithReturnsFalseReverts() 595206 600803 5597
testTransferWithReturnsTooLittleReverts() 595053 600666 5613
testTransferWithReturnsTooMuch() 619006 624778 5772
testTransferWithRevertingReverts() 595165 600825 5660
testTransferWithStandardERC20() 618894 624816 5922
testTryTransferAllETH() 148742 148720 -22
testTryTransferETH() 148723 148767 44
testTryTransferETHWithNoGrief() 537069 537047 -22
testTryTransferETHWithNoStorageWrites() 192488 192466 -22
test__codesize() 72315 72677 362
testCheckBalanceOfNonImplemented() - 3343 -

@Vectorized Vectorized merged commit e2509fb into main Apr 2, 2025
13 checks passed
@Vectorized Vectorized deleted the check-balance-of branch April 2, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant