✨ toNibbles #1461
Open
✨ toNibbles #1461
+60
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xClandestine
suggested changes
Aug 4, 2025
src/utils/LibBit.sol
Outdated
Comment on lines
209
to
210
| mstore(add(o, add(i, i)), | ||
| and(0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f, or(shl(4, x), x))) |
There was a problem hiding this comment.
This method should respect each nibbles original height within it's expanded byte (e.g. hex"ABCD" -> hex"A00BC00D"). My bad, I wasn't clear enough in my issue.
This should fix it:
Suggested change
| mstore(add(o, add(i, i)), | |
| and(0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f, or(shl(4, x), x))) | |
| let mask := 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f | |
| mstore(add(o, add(i, i)), or(shl(8, and(x, not(mask))), and(x, mask))) |
There was a problem hiding this comment.
wait… is the original optimism code the same?
There was a problem hiding this comment.
Shit, no just confirmed your first implementation was correct. Was thinking of my private fork where I'm working on another optimization that reduces some logic down the line in MerkleTrie. Disregard the last commit, mbmb.
Co-authored-by: clandestine.eth <[email protected]>
Comment on lines
+209
to
+210
| let mask := 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f | ||
| mstore(add(o, add(i, i)), or(shl(8, and(x, not(mask))), and(x, mask))) |
There was a problem hiding this comment.
Disregard bad suggestion:
Suggested change
| let mask := 0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f | |
| mstore(add(o, add(i, i)), or(shl(8, and(x, not(mask))), and(x, mask))) | |
| mstore(add(o, add(i, i)), | |
| and(0x0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f0f, or(shl(4, x), x))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1459
Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge fmt?forge test?Pull requests with an incomplete checklist will be thrown out.