Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.2.1 #60

Merged
merged 20 commits into from
Feb 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .ansible-lint
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,10 @@ use_default_rules: true

# This makes linter to fully ignore rules/tags listed below
skip_list:
- no-handler
- line-length
- truthy
- var-naming[no-role-prefix]
- yaml[line-length]
- name[template]
- ignore-errors

# Report only a subset of tags and fully ignore any others
# tags:
Expand Down
56 changes: 6 additions & 50 deletions .github/workflows/ansible-lint.yml
Original file line number Diff line number Diff line change
@@ -1,55 +1,11 @@
name: Ansible Lint # feel free to pick your own name

# .github/workflows/ansible-lint.yml
name: ansible-lint
on: [push, pull_request]

jobs:
build:

name: Ansible Lint # Naming the build is important to use it as a status check
runs-on: ubuntu-latest

steps:
# Important: This sets up your GITHUB_WORKSPACE environment variable
- uses: actions/checkout@v2

- name: Lint Ansible Playbook
# replace "master" with any valid ref
uses: ansible/ansible-lint-action@v4-eol
with:
# [required]
# Paths to ansible files (i.e., playbooks, tasks, handlers etc..)
# or valid Ansible directories according to the Ansible role
# directory structure.
# If you want to lint multiple ansible files, use the following syntax
# targets: |
# playbook_1.yml
# playbook_2.yml
targets: ""
# [optional]
# Arguments to override a package and its version to be set explicitly.
# Must follow the example syntax.
# ansible-lint =>5.0.0 is required for proper linting of collections
override-deps: |
ansible-lint==5.4.0
# [optional]
# Arguments to be passed to the ansible-lint

# Options:
# -q quieter, although not silent output
# -p parseable output in the format of pep8
# --parseable-severity parseable output including severity of rule
# -r RULESDIR specify one or more rules directories using one or
# more -r arguments. Any -r flags override the default
# rules in ansiblelint/rules, unless -R is also used.
# -R Use default rules in ansiblelint/rules in addition to
# any extra
# rules directories specified with -r. There is no need
# to specify this if no -r flags are used
# -t TAGS only check rules whose id/tags match these values
# -x SKIP_LIST only check rules whose id/tags do not match these
# values
# --nocolor disable colored output
# --exclude=EXCLUDE_PATHS
# path to directories or files to skip. This option is
# repeatable.
# -c C Specify configuration file to use. Defaults to ".ansible-lint"
args: ""
- uses: actions/checkout@v4
- name: Run ansible-lint
uses: ansible/[email protected] # or version tag instead of 'main'
4 changes: 1 addition & 3 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
.DS_Store
.vscode
.cache

# Ansible
__pycache__
*.retry
plugins/modules/__pycache__
44 changes: 44 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
==============================
veeamhub.veeam Release Notes
==============================

.. contents:: Topics

This changelog describes changes after version 1.5.0.

v2.2.1
======

Breaking Changes
-------------

- Changed default ISO checksum algorithm from SHA256 to SHA1 (https://github.com/VeeamHub/veeam-ansible/issues/46)

Major Changes
-------------

- Added support for new silent install process available in version 12.1 (https://helpcenter.veeam.com/docs/backup/vsphere/install_vbr_answer_file.html?ver=120)
- Added support for new silent install process available in version 12.1 (https://helpcenter.veeam.com/docs/backup/vsphere/upgrade_vbr_answer_file.html?ver=120)
- Added support for Veeam Backup & Replication Console 12.1 install (https://helpcenter.veeam.com/docs/backup/vsphere/install_console_answer_file.html?ver=120)
- Added support for Veeam Backup & Replication Console 12.1 upgrade (https://helpcenter.veeam.com/docs/backup/vsphere/upgrade_console_answer_file.html?ver=120)

Minor Changes
-------------

- Updated ISO to version 12.1 (https://github.com/VeeamHub/veeam-ansible/issues/59)
- Updated logic for ISO download (https://github.com/VeeamHub/veeam-ansible/issues/57)
- Added support for specifying install directory for 12.1 and later (https://github.com/VeeamHub/veeam-ansible/issues/51)
- Added support for installing VBR plugins for 12.1 and later (https://github.com/VeeamHub/veeam-ansible/issues/25)
- Updated ansible-lint - Now using ansible-lint 6.22.2 (https://github.com/VeeamHub/veeam-ansible/issues/33)
- Updated collection dependencies - Validated this collection supports the most current version of dependencies (ansible.windows/community.windows)

Bugfixes
--------

- Fixed lint errors - Made necessary changes to conform with current best practices
- Added retry when starting Veeam services (https://github.com/VeeamHub/veeam-ansible/issues/54)

Deprecations
--------

- Dropping support for installing version 10
4 changes: 2 additions & 2 deletions docs/docsite/rst/veeam_vbr_rest.rst
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ End-to-End Create Veeam Job:
ansible.builtin.debug:
var: repo_testout
- name: Filter Repo Object
set_fact:
ansible.builtin.set_fact:
repo_id: "{{ repo_testout | json_query(repos_id_query) }}"
vars:
repos_id_query: "infrastructure_repositories.data[?name==`{{ repo_name }}`].id"
Expand Down Expand Up @@ -247,7 +247,7 @@ End-to-End Delete Veeam Job:
ansible.builtin.debug:
var: job_testout
- name: Filter Job Object
set_fact:
ansible.builtin.set_fact:
job_id: "{{ job_testout | json_query(jobs_id_query) }}"
vars:
jobs_id_query: "infrastructure_jobs.data[?name==`{{ job_name }}`].id"
Expand Down
7 changes: 4 additions & 3 deletions galaxy.yml
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
---
namespace: "veeamhub"
name: "veeam"
version: "1.5.0"
version: "2.2.1"
readme: "readme_galaxy.md"
authors:
- "Chris Arceneaux (https://www.arsano.ninja/)"
- "Markus Kraus (https://mycloudrevolution.com/)"
description: Administer Veeam Software
license_file: "LICENSE"
tags:
- application
- veeam
- availability
- suite
Expand All @@ -24,7 +25,7 @@ tags:
- vem
- em
dependencies:
ansible.windows: '1.13.0'
community.windows: '1.12.0'
ansible.windows: '2.2.0'
community.windows: '2.1.0'
repository: "https://github.com/VeeamHub/veeam-ansible"
issues: "https://github.com/VeeamHub/veeam-ansible/issues"
2 changes: 1 addition & 1 deletion meta/runtime.yml
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
requires_ansible: '>=2.12'
requires_ansible: '>=2.14.0'
12 changes: 6 additions & 6 deletions plugins/modules/veeam_software_check.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,12 @@


- name: Checking to see if Veeam software is installed
veeam_software_check:
name: "Veeam*"
allow_multiple: true
register: software
- debug:
var: software.output | from_json
veeam_software_check:
name: "Veeam*"
allow_multiple: true
register: software
- ansible.builtin.debug:
var: software.output | from_json
'''

RETURN = r'''
Expand Down
6 changes: 3 additions & 3 deletions plugins/modules/veeam_vbr_rest_jobs_manage.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
hosts: localhost
gather_facts: false
vars:
- repo_name: '<Repository Name>'
repo_name: '<Repository Name>'
tasks:
- name: Get VBR Repos
veeamhub.veeam.veeam_vbr_rest_repositories_info:
Expand All @@ -67,7 +67,7 @@
ansible.builtin.debug:
var: repo_testout
- name: Filter Repo Object
set_fact:
ansible.builtin.set_fact:
repo_id: "{{ repo_testout | json_query(repos_id_query) }}"
vars:
repos_id_query: "infrastructure_repositories.data[?name==`{{ repo_name }}`].id"
Expand Down Expand Up @@ -105,7 +105,7 @@
ansible.builtin.debug:
var: job_testout
- name: Filter Job Object
set_fact:
ansible.builtin.set_fact:
job_id: "{{ job_testout | json_query(jobs_id_query) }}"
vars:
jobs_id_query: "infrastructure_jobs.data[?name==`{{ job_name }}`].id"
Expand Down
2 changes: 1 addition & 1 deletion plugins/modules/veeam_vbr_upgrade_job_prep.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@

EXAMPLES = r'''
- name: Defining Backup Job file for exporting disabled jobs
set_fact:
ansible.builtin.set_fact:
jobs_file: "C:\\install\\DisabledJobs{{ ansible_date_time.iso8601_basic_short }}.csv"
- name: Stopping and disabling all backup jobs
veeam_vbr_upgrade_job_prep:
Expand Down
Loading
Loading