Added strong name (signed) #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 18, 2018 14:12
…ed project to new VS2017 format with build targets of .NET 4, 4.5, Std1.3 and Std2.0. Migrated .nuspec content to new project eliminating need for separate builds and nuget packing.
|
Thanks @dahall! Had a quick look and it all looks good. I will merge these changes as soon as I get back to my office. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #16, there are 3 commits here. The first one (Added strong name...) is the one that is most critical. The others came as I was trying to make this work on my system and could be ignored if they still build in yours. Address #18, I have changed the csproj for the main assembly to make it VS2017 compliant and handle multi-targeting.