-
Notifications
You must be signed in to change notification settings - Fork 19
Implementation of Features from #489 #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
switch (symbol) { | ||
case EPSILON: return "<eps>"; | ||
default: break; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be simpler:
switch (symbol) { | |
case EPSILON: return "<eps>"; | |
default: break; | |
} | |
if (symbol == EPSILON) { | |
return "<eps>"; | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know. I put the switch there on purpose, so when we introduce new — I don't know how many — symbols, it won't become a mess of if-else statements.
Can we merge this PR, or do we plan to work on this more? |
It's done. We can merge it. |
This PR extends the functionality of print_to_dot. And closes #489
It now:
Optional: