Skip to content

Python Binding Fix #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

Python Binding Fix #530

merged 1 commit into from
May 12, 2025

Conversation

koniksedy
Copy link
Collaborator

This PR (hopefully) fixes the bug in the Python binding for NFA and closes #528.

The bug was caused by the existence of both transitions and transitions() in CDelta.

@koniksedy koniksedy requested review from jurajsic and Adda0 May 12, 2025 13:41
Adda0
Adda0 approved these changes May 12, 2025
View reviewed changes
Copy link
Collaborator

@Adda0 Adda0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that is the problem. The new version of Cython is stricter about these issues, such as defining nonexisting types even though they are not used. Thanks.

@Adda0 Adda0 merged commit c75e3c1 into devel May 12, 2025
15 checks passed
@Adda0 Adda0 deleted the binding_bug branch May 12, 2025 13:54
@Adda0 Adda0 mentioned this pull request May 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jurajsic jurajsic jurajsic approved these changes

@Adda0 Adda0 Adda0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot install the python binding
3 participants
@koniksedy @jurajsic @Adda0