add python annotation files #543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add `-> None` for functions without return type; remove `__new__` functions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #543 +/- ##
==========================================
- Coverage 75.88% 74.54% -1.34%
==========================================
Files 43 43
Lines 6476 6569 +93
Branches 1437 1458 +21
==========================================
- Hits 4914 4897 -17
- Misses 1031 1143 +112
+ Partials 531 529 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
add some missing imports; replace some C++ types with Python types; reorganize some literals.
Adda0
reviewed
Jun 17, 2025
This file was initially created because I misunderstood the meaning of `namespace package` in the Python typing documentation (they need separate `py.typed` files for each subpackage).
Adda0
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These files are hand-written, and should be manually maintained in the future. Be careful about potential errors!
I tried several automatic
pyigeneration tools available on GitHub, but none of them is usable enough, so in the end I wrote them by hand (mostly by copy-and-paste).setup.pyis not changed in this file, because these files are automatically included (see this documentation). However, this feature is experimental and may change in the future, so take your own risk.closes #532 .