Enable Strict Concurrency mode #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
emildzwonek
commented
Aug 2, 2024
emildzwonek
commented
- Enable strict concurrency mode
- Bump minimal OS versions (required by swift-tools-version:5.10)
- Tweak codebase to build with strict concurrency mode without warnings
| @@ -60,23 +60,23 @@ extension URLSession { | |||
| method: HTTPMethod, | |||
| parameters: ParametersEncoding?, | |||
| headers: HTTPHeaders?, | |||
| decoder: DataDecoder | |||
| decoder: @autoclosure @escaping @Sendable () -> DataDecoder | |||
There was a problem hiding this comment.
does it have to be escaping here?
There was a problem hiding this comment.
Good catch, removed
| } | ||
|
|
||
| // MARK: - Private | ||
|
|
||
| private static func handle<T: Decodable>( | ||
| response: HTTPURLResponse, | ||
| data: Data, | ||
| decoder: DataDecoder, | ||
| decoder: @autoclosure @escaping @Sendable () -> DataDecoder, |
There was a problem hiding this comment.
Good catch, removed
pwszebor-vimn
approved these changes
Aug 2, 2024
laurentiuionescu-viacom
approved these changes
Aug 2, 2024
| .tvOS(.v11), | ||
| .macOS(.v13), | ||
| .iOS(.v12), | ||
| .tvOS(.v12), |
There was a problem hiding this comment.
Just bumped it to the oldest recommended version. We won't get any benefit from v15 here, v16 would make a difference
laurentiuionescu-viacom
approved these changes
Aug 2, 2024
vladkleshchanka
approved these changes
Aug 2, 2024
emildzwonek
force-pushed
the
strict-concurrency
branch
2 times, most recently
from
cc97651 to
e62bd32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.