fix chown syntax #37
Merged
fix chown syntax #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some `chown` binaries seem to support the `.` notation, but a few don't. I haven't looked into why that is. Since `:` is the arguably ubiquitous, conventional, and universal (?) syntax, I'm changing it to head in that direction. That said, usage of `copy.sh` should probably be phased out, anyway, and the from-rust-built binary `copy` should be used instead.
kanaka
approved these changes
Jan 28, 2025
jonsmock
approved these changes
Jan 28, 2025
The colon format is the one specified by POSIX. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some
chownbinaries seem to support the.notation, but a few don't. I haven't looked into why that is. Since:is the arguably ubiquitous, conventional, and universal (?) syntax, I'm changing it to head in that direction. That said, usage ofcopy.shshould probably be phased out, anyway, and the from-rust-built binarycopyshould be used instead.