Skip to content

add rate_prometheus semantics #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

add rate_prometheus semantics #53

merged 1 commit into from
Jun 11, 2025

Conversation

hagen1778
Copy link
Contributor

@hagen1778 hagen1778 requested review from makasim, f41gh7 and jiekun June 5, 2025 13:24
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.06%. Comparing base (682e8d8) to head (05dcf12).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   88.87%   91.06%   +2.19%     
==========================================
  Files          11       11              
  Lines        3650     3975     +325     
==========================================
+ Hits         3244     3620     +376     
+ Misses        308      271      -37     
+ Partials       98       84      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

hagen1778 added a commit to VictoriaMetrics/VictoriaMetrics that referenced this pull request Jun 5, 2025
support [rate_prometheus](https://docs.victoriametrics.com/victoriametrics/metricsql/#rate_prometheus) function, an equivalent to `increase_prometheus(series_selector[d]) / d`

#8901

------------

Depends on VictoriaMetrics/metricsql#53

Signed-off-by: hagen1778 <[email protected]>
Copy link
Contributor

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hagen1778
Copy link
Contributor Author

@f41gh7 would you mind checking VictoriaMetrics/VictoriaMetrics#9110 too?

@f41gh7 f41gh7 merged commit bbbc377 into master Jun 11, 2025
7 checks passed
@f41gh7
Copy link
Contributor

f41gh7 commented Jun 11, 2025

Thanks for contribution!

@f41gh7 f41gh7 deleted the rate-prometheus branch June 11, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants