Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GTE_GTC as timeInForce for STOP_MARKET and TAKE_PROFIT_MARKET orders #573

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tim142857
Copy link

There was an issue when we create both STOP_MARKET and TAKE_PROFIT_MARKET for an opened position. When one is trigerred, second order is still active. GTE_GTC allow orders to be removed if their status become "EXPIRED"

@balthazar
Copy link
Member

Actually shouldn't you be the one providing this param yourself rather than making this the default which some people might not expect?

@farukborann
Copy link
Contributor

farukborann commented Sep 19, 2023

I agree, it should not be set by default, but we can set it ourselves.

Something like that :

File: ./node_modules/binance-api-node/index.d.ts
Line 1412 : 
  export type TimeInForce_LT = 'GTC' | 'IOC' | 'FOK' | 'GTE_GTC'

  export const enum TimeInForce {
    GTC = 'GTC',
    IOC = 'IOC',
    FOK = 'FOK',
    GTE_GTC = 'GTE_GTC'
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants