Support multiple levels of relations #91
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`buildFilter()` aliases relations that are not OneToOne, but `fullColumnName()` does not, the result being that filters on fields nested in HasMany or ManyToMany relations fail. This commit makes the `fullColumnName()` method alias all such relations.
There are 3 cases to consider rather than 2: 1. Is not a relation 2. Is a relation and !isOneToOne 3. Is a relation and isOneToOne
…ture/multi_level_relations
Objection Find is now supports multiple levels of depth. Subqueries replaced with joins during the process.
- GroupBy key column added as a default - GroupBy parameter is added only if there are joins
Update FindQueryBuilder.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds filter support for n levels of relations (e.g. person.neighbor.pet.name:eq "fido") to fix #17 and #79.
In order to do so, subqueries have been replaced with joins. The first step the FindQueryBuilder performs joins all related tables and adds aliases on each. Then, the filter queries are built using these aliases.
The PropertyRef class has been updated as well:
relationproperty is nowrelationsin order to hold multiple levels or relational fields.modelClassesproperty to hold the models represented by a query (using the example above: [Person, Person, Animal]).