Add checks for generic types and discard any unexpected types #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a 21 (#355) * Fix switches with enums for enums in other classes and null cases * Remove println
* Fix if statements inside switch statements preventing switch expressions * Update test output * Fix switch statements that throw an exception not being converted * Add comment
* Fix local class methods not getting the parent context * Add test
) They may be needed later when writing other classes. This fixes an issue where non-static inner class constructor invocations from foreign classes would inconsistently have the synthetic enclosing this instance removed from the parameter list, depending on the order they were processed in (and consequently having strange interactions with multithreaded writing)
* Don't write explicit casts where redundant * Fix numeric parameter disambiguation * Write casts when not doing so would change behavior * Fix failing test --------- Co-authored-by: Jasmine Karthikeyan <[email protected]>
* add option to exclude classes from decompilation * add @type annotation * rename into excluded-classes, remove short name
* Default arguments in function / constructor declarations * Improve defaults detection and parsing, and add option for unknown defaults * Fix ambiguous wording * Clean up with J12-17 features * Describe in detail what happens to default parameters * Fix cases with 32 or more parameters * Improve wording about default constructors * Clean up imports * Fix problems with long/double parameters
…kes up multiple lines before reformatting (like an anonymous class instantiation) (#379)
* Simplify empty anonymous class bodies to `{}`
This is typically how people actually write code like this (as can be seen in the existing tests)
The improvement is extra noticeable with things like type tokens
* Switch to AtomicBoolean and add comments
…he number (#395) * Add failing test for number casts issue * make sure to include casts for numeric operations
* Fix variable used in switch head not being inlined * Update dec files * Comments and put streams on multiple lines
…or (#401) synthetic parameters
* Fix intersection casts for direct methods * Add support for variable assignments * Use var for variables that represent intersection types and update tests * Add comments and remove println * Add support for when an intersection type is casted back to it's original type
Co-authored-by: coehlrich <[email protected]>
…fields disappearing
* Allow plugins to change decompiled file extensions * Address review comments
… method (#423) * Fix lambdas in anonymous classes referencing parameters from the root method * Update test
…tionExprent broke
* chore(deps): Bump GHA versions * chore(deps): Bump Gradle and plugin versions
Also upload the intended test result for TestCorruptedSignatures
|
How do these checks work when signatures depend on each other? For example, a field that initially has a valid signature, but its type class's signature does not pass the check and is modified/removed, which in turn then invalidates that field's signature. |
jaskarth
force-pushed
the
develop/1.11.0
branch
2 times, most recently
from
a6698b7 to
0be304f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #409 by adding checks and discarding any clearly bogus generics