Skip to content

VCST-3449: PickupLocationId for order query #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 23, 2025
Merged

VCST-3449: PickupLocationId for order query #29

merged 10 commits into from
Jul 23, 2025

Conversation

basilkot
Copy link
Contributor

@basilkot basilkot commented Jul 1, 2025 •
edited by vc-ci
Loading

Description

  • Save PickupLocationid for CreateOrderFromCart mutation
  • Return PickupLocation for Order query

Changes for GetFullOrder query

fragment fullOrderFields on CustomerOrderType {
  shipments {
    pickupLocation {
      id,name,description,geoLocation,deliveryDays,storageDays,contactEmail,contactPhone,workingHours,isActive
      address {
        id,key,name,organization,countryCode,countryName,city,postalCode,line1,line2,regionId,regionName,phone,email,outerId,description,addressType
      }
    }
    ...
  }
  ...
}

References

QA-test:

Jira-link:

https://virtocommerce.atlassian.net/browse/VCST-3449

Artifact URL:

https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.XOrder_3.913.0-pr-29-2fc4.zip

@basilkot basilkot requested a review from artem-dudarev July 1, 2025 08:14
vc-ci
vc-ci reviewed Jul 1, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.466
Timestamp: 01-07-2025T12:56:20

vc-ci
vc-ci reviewed Jul 1, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.314
Timestamp: 01-07-2025T13:23:51

vc-ci
vc-ci reviewed Jul 7, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.459
Timestamp: 07-07-2025T11:47:28

vc-ci
vc-ci reviewed Jul 10, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.093
Timestamp: 10-07-2025T11:15:41

basilkot added 2 commits July 11, 2025 11:04
@basilkot
update deps
cbe5626
@basilkot
Merge branch 'feat/VCST-3449' of https://github.com/VirtoCommerce/vc-…
4858afb 
…module-x-order into feat/VCST-3449

# Conflicts:
#	src/VirtoCommerce.XOrder.Core/VirtoCommerce.XOrder.Core.csproj
#	src/VirtoCommerce.XOrder.Web/module.manifest
vc-ci
vc-ci reviewed Jul 11, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.246
Timestamp: 11-07-2025T10:18:39

vc-ci
vc-ci reviewed Jul 21, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.939
Timestamp: 21-07-2025T15:16:14

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
2 Accepted issues

Measures
0 Security Hotspots
2.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

vc-ci
vc-ci reviewed Jul 23, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.736
Timestamp: 23-07-2025T19:32:46

vc-ci
vc-ci reviewed Jul 23, 2025
View reviewed changes
Copy link
Contributor

@vc-ci vc-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Suite: Test Suites/Modules/module_Assets
Tests: 13
Failures: 0
Errors: 0
Time: 7.186
Timestamp: 23-07-2025T19:42:50

@ksavosteev ksavosteev merged commit 39eed9e into dev Jul 23, 2025
8 checks passed
@ksavosteev ksavosteev deleted the feat/VCST-3449 branch July 23, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vc-ci vc-ci vc-ci left review comments

@artem-dudarev artem-dudarev artem-dudarev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@basilkot @artem-dudarev @vc-ci @ksavosteev @Lenajava1 @ekuvirto