Cljarvis 4 7 transcript

[ClJarvis]

Improve transcription Season 4 Episode 7

Description

This PR improves transcript Season 4 Episode 7 with Jessica Wilkins. Growing your tech career through writing.

Related Issue

Closes #52

[adiati98]

Hey @ClJarvis,
Does with this PR mean that you want to close #110?

Also, when I run yarn check-srt, I can see many lines have incorrect timestamps.

As I mentioned I haven't checked the whole thing.
Can you please check and fix everything's needed before I or @danieltott can review your PR?
Thank you 🙂

[ClJarvis]

Yes close the other one. I'll work on this one.

[ClJarvis]

Still working on it. Not sure why it dislike the first time speakers are mentioned. Or which 00 it is referring to.

checking 4_7.srt
possible bad names / colon error:

• Bekah Hawrot Weigel
• Dan Ott
• Jessica Wilkins
• 00

[adiati98]

Still working on it. Not sure why it dislike the first time speakers are mentioned. Or which 00 it is referring to.

checking 4_7.srt possible bad names / colon error:

• Bekah Hawrot Weigel
• Dan Ott
• Jessica Wilkins
• 00

We are now working with new guidelines. So, use only the first name of each speaker: Bekah, Dan, and Jessica.

As for the 00, there's no other way than to search it manually 😅.

[ClJarvis]

There was a double timestamp. it has been removed. srt-check run without errors.

[adiati98]

@ClJarvis let me know when it's ready for review :)
It may take a while, so I'll make sure to add hacktoberfest-accepted label if I'm not done reviewing in 3 days.

[adiati98]

@danieltott this PR is ready for final review. Thank you! :)

[ClJarvis]

Thanks, I will be off line most of the weekend. So If there's changes need I won't be able to get to them till Monday.

[ClJarvis]

Is this ready to be merged? Any changes needed?

[adiati98]

@ClJarvis, there are no changes needed. @danieltott will merge this when he uploads it to Buzzsprout 🙂