fix: convert nav social links to individual list items to improve accessibility#1293
Merged
meg-gutshall merged 2 commits intoVirtual-Coffee:mainfrom Dec 12, 2024
Conversation
👷 Deploy Preview for virtual-coffee-io processing.
|
Contributor
|
This is such a great catch!!! |
Contributor
|
Thank you, @Insider32 ! That's a great catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey everyone, I like your community's initiative and wanted to make a small contribution on improving the website. Please let me know if the original implementation was intended for some reason or if you see some problem with my changes. Thanks!
Description
This PR addresses an issue where the navbar's second list (the one with the social links - github, X, youtube ) is announced with 1 link item by screen readers due to the fact that all links are into a single
lielement.To fix this issue, each link has been added to an individual list item and CSS classes have been adjusted (moved to
ulelement) to maintain the original visuals. As a result, screen readers will now announce the list with 3 items.Methodology
Changes are suggested to improve accessibility.
Code of Conduct