Skip to content

Add Multiple Calendar Options to Add to Calendar Link on Events Page#1320

Merged
danieltott merged 3 commits intoVirtual-Coffee:mainfrom
fuyalasmit:asmit/1319
Feb 5, 2025
Merged

Add Multiple Calendar Options to Add to Calendar Link on Events Page#1320
danieltott merged 3 commits intoVirtual-Coffee:mainfrom
fuyalasmit:asmit/1319

Conversation

@fuyalasmit
Copy link
Contributor

Linked Issue

Closes: #1319

Description

This PR improves the functionality of the event calendar feature. Previously, the "Add to Calendar" option was a simple link for downloading the .ics file. Now, I have introduced SVG icons to make the UI more visually appealing while maintaining its functionality.

Before

image

After

image

Methodology

Continued using calendar-link as implemented by Joe in this PR

Code of Conduct

By submitting this pull request, you agree to follow our Code of Conduct

@fuyalasmit fuyalasmit requested a review from a team as a code owner February 4, 2025 13:53
@netlify
Copy link

netlify bot commented Feb 4, 2025

👷 Deploy Preview for virtual-coffee-io processing.

Name Link
🔨 Latest commit 9da687d
🔍 Latest deploy log https://app.netlify.com/sites/virtual-coffee-io/deploys/67a377f936ec8100083d2e68

Copy link
Member

@danieltott danieltott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fuyalasmit thanks for this PR!

In general the approach is great. I have a couple changes we'll need to merge.

  • In the icon files, all of the svg attributes need to be set in JSX style, not html/svg style. So fill-rule needs to be fillRule, etc.
  • The links (<a href... />) should have a title prop set
  • The icon files also need to have a <title /> element. Your components have a title prop, but they aren't using it. Example:
    <title id="googleSvgTitle">{title}</title>
  • The icon files also need to have role="img" and aria-labelledby="googleSvgTitle" (for example) props set.
  • The general ICS icon isn't really ideal. Let's replace that with perhaps a calendar icon (similar to the apple calendar icon maybe?)

Let me know if you have any questions here!

@fuyalasmit
Copy link
Contributor Author

Okay, thank you for the suggestion, @danieltott
I have made the changes, please take a look.

Copy link
Member

@danieltott danieltott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @fuyalasmit ! Thanks for getting those changes in so fast 🙌

@danieltott danieltott merged commit 7729d52 into Virtual-Coffee:main Feb 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Multiple Calendar Options to 'Add to Calendar' Link on Events Page

2 participants