Add Multiple Calendar Options to Add to Calendar Link on Events Page#1320
Merged
danieltott merged 3 commits intoVirtual-Coffee:mainfrom Feb 5, 2025
Merged
Add Multiple Calendar Options to Add to Calendar Link on Events Page#1320danieltott merged 3 commits intoVirtual-Coffee:mainfrom
danieltott merged 3 commits intoVirtual-Coffee:mainfrom
Conversation
👷 Deploy Preview for virtual-coffee-io processing.
|
danieltott
requested changes
Feb 4, 2025
Member
danieltott
left a comment
There was a problem hiding this comment.
@fuyalasmit thanks for this PR!
In general the approach is great. I have a couple changes we'll need to merge.
- In the icon files, all of the svg attributes need to be set in JSX style, not html/svg style. So
fill-ruleneeds to befillRule, etc. - The links (
<a href... />) should have atitleprop set - The icon files also need to have a
<title />element. Your components have atitleprop, but they aren't using it. Example:<title id="googleSvgTitle">{title}</title>
- The icon files also need to have
role="img"andaria-labelledby="googleSvgTitle"(for example) props set. - The general ICS icon isn't really ideal. Let's replace that with perhaps a calendar icon (similar to the apple calendar icon maybe?)
Let me know if you have any questions here!
Contributor
Author
|
Okay, thank you for the suggestion, @danieltott |
ebf8b9e to
f1f4289
Compare
danieltott
approved these changes
Feb 5, 2025
Member
danieltott
left a comment
There was a problem hiding this comment.
This is great @fuyalasmit ! Thanks for getting those changes in so fast 🙌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes: #1319
Description
This PR improves the functionality of the event calendar feature. Previously, the "Add to Calendar" option was a simple link for downloading the .ics file. Now, I have introduced SVG icons to make the UI more visually appealing while maintaining its functionality.
Before
After
Methodology
Continued using calendar-link as implemented by Joe in this PR
Code of Conduct