fix broken map marker images on the members map#1421
Merged
danieltott merged 10 commits intoVirtual-Coffee:mainfrom Oct 14, 2025
Merged
fix broken map marker images on the members map#1421danieltott merged 10 commits intoVirtual-Coffee:mainfrom
danieltott merged 10 commits intoVirtual-Coffee:mainfrom
Conversation
👷 Deploy Preview for virtual-coffee-io processing.
|
Re-enable development mode message for MemberMap component.
Contributor
meg-gutshall
left a comment
meg-gutshall
left a comment
There was a problem hiding this comment.
Hey @pedaars! Thanks for looking into this further.
We definitely want to keep the updates in the package.json file. Unfortunately, the changes in the MemberMap.tsx file didn't solve the issue.
Perhaps you can pair with another member who is visually seeing the bug? It's difficult to fix a bug you're not experiencing yourself!
…mages. Signed-off-by: Joe Karow <[email protected]>
Member
|
To fix the broken images, I switched to use the base I believe |
danieltott
approved these changes
Oct 14, 2025
Member
danieltott
left a comment
danieltott
left a comment
There was a problem hiding this comment.
Great work! I love a team effort 💙
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
closes #1400
Description
fix broken map marker images on the members map
@meg-gutshall can you test this fix please?
Methodology
updated both the
"react-leaflet": "^5.0.0"and"react-leaflet-cluster": "^3.1.1"packages to fix the MapContainer already initialized bug I was seeing reported here hereI am 95% sure the above is what was causing the issues
updated the way the fallback icon was imported to fix the broken image being rendered on the map
Code of Conduct