Feat/animate enhance #3870
Merged
Feat/animate enhance #3870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
vchart
chore
typescript
react-vchart
docs
openinula-vchart
labels
xile611
reviewed
Apr 3, 2025
| * 水平柱状图拆分策略 | ||
| * 针对水平柱状图，先更新y和height，再更新x和width | ||
| */ | ||
| export class HorizontalBarSplitStrategy implements IAnimationSplitStrategy { |
Contributor
There was a problem hiding this comment.
按照代码规范，最好不要把两个 class 定义放在一个文件里面
Contributor
Author
There was a problem hiding this comment.
按照代码规范，最好不要把两个 class 定义放在一个文件里面
已修改
| .find(e => e.context.data[0]?.[DEFAULT_DATA_INDEX] < dataIndex); | ||
| if (outState.includes(state)) { | ||
| return prevMarkElement?.getNextGraphicAttributes()?.endAngle; | ||
| return prevMarkElement?.getFinalAttribute()?.endAngle; |
Contributor
There was a problem hiding this comment.
vrender getFinalAttribute 是什么含义？只有这里需要改成这个api吗
Contributor
Author
There was a problem hiding this comment.
vrender
getFinalAttribute是什么含义？只有这里需要改成这个api吗
就是获取最终的属性，只要有动画，就用这个拿到encode出来的属性
| /** | ||
| * 用于保存mark对应series的fieldX | ||
| */ | ||
| _originalFieldX?: string[]; |
| if (!this._animationConfig) { | ||
| return false; | ||
| } | ||
| return Object.keys(this._animationConfig).length > 0; |
Contributor
There was a problem hiding this comment.
这里应该会有问题，this._animationConfig 里面会有如下配置吧：
{
state: false
}
Contributor
Author
There was a problem hiding this comment.
没有，_animationConfig是个对象，里面结构如下
{
"appear": [
{
"duration": 300,
"easing": "cubicOut",
"type": "growHeightIn"
}
],
"update": [
{
"type": "update",
"duration": 300,
"easing": "linear"
}
],
"enter": [
{
"duration": 300,
"easing": "linear",
"type": "growHeightIn"
}
],
"exit": [
{
"duration": 300,
"easing": "linear",
"type": "growHeightOut",
"controlOptions": {
"stopWhenStateChange": true
}
}
],
"disappear": [
{
"duration": 500,
"easing": "cubicIn",
"type": "growHeightOut"
}
],
"state": {
"duration": 300,
"easing": "linear"
}
}| // 有可能又被复用了，所以这里需要判断，如果还是在exiting阶段的话才删除 | ||
| // TODO 这里如果频繁执行的话，可能会误判 | ||
| if (g.isExiting) { | ||
| this._graphicMap.delete(key); |
Contributor
There was a problem hiding this comment.
下面这段代码有重复使用，可以抽一个函数
this._graphicMap.delete(key);
if (g.parent) {
g.parent.removeChild(g);
}
if (g.release) {
g.release();
}
| if (planner.state === 'exit') { | ||
| planner.graphics.forEach(g => { | ||
| if (g.isExiting) { | ||
| (this as any)._graphicMap.delete(g.context.uniqueKey); |
Contributor
There was a problem hiding this comment.
下面的代码出现了三次了，可以抽象一个函数
(this as any)._graphicMap.delete(g.context.uniqueKey);
if (g.parent) {
g.parent.removeChild(g);
}
if (g.release) {
g.release();
}
| ); | ||
|
|
||
| // 按顺序执行planner | ||
| this._executePlanners(planners, 0); |
Contributor
There was a problem hiding this comment.
如果有多个 planners ，是什么时机去执行 index > 0 的planner?
| const enterGraphics: IMarkGraphic[] = []; | ||
| const appearGraphics: IMarkGraphic[] = []; | ||
|
|
||
| const fieldX = (this.mark.model as any).fieldX; |
Contributor
Author
There was a problem hiding this comment.
接口上mark是有model的，this.mark就是图元mark
|
|
||
| // 保存原始fieldX/fieldY以供比较 | ||
| if (context.fieldX) { | ||
| context._originalFieldX = context.fieldX; |
| context.fieldY = fieldY; | ||
|
|
||
| const state = defaultState ?? g.context.animationState; | ||
| switch (state) { |
Contributor
There was a problem hiding this comment.
其实现在。animationState 和。diffState. 就是一样的，这样反复处理，有必要吗
neuqzxy
force-pushed
the
feat/animate-enhance
branch
from
4813af1 to
e9bfb53
Compare
…ieldX/Y, remove defaultState params
xile611
force-pushed
the
feat/animate-enhance
branch
from
7af479f to
b677cfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
🔗 Related PR link
🐞 Bugserver case id
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough