refactor: rework candidate value collection and filtering logic in value filter #4754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 新增 filterMenuStates 管理筛选菜单状态，包含稳定候选值与当前搜索关键词 - 新增初始化状态、更新搜索关键词、按搜索获取可见已选值的方法 - 更新 ValueFilter 接入新状态管理，确保筛选与选择时正确处理可见值
* 在 FilterToolbar 中订阅筛选状态变化，用于更新“清除筛选”按钮状态 * 新增 updateClearFilterButtonState 方法，根据激活的筛选管理按钮可见性 * 重构 ValueFilter：改为收集不计数的唯一值，并基于筛选状态更新候选计数 * 优化筛选项初始化：仅允许计数 > 0 的值可选
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
在筛选插件中，重构了按值筛选器的候选值搜集和筛选应用逻辑
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough