improved gadm setup with reworked pipe #448
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| simplification_tolerance, preserve_topology=preserve_topology | ||
| # we ensure that the areas of this countries match the area used in the excel sheet | ||
| country_size_ha = { | ||
| "USA": 947084624.2706754, |
There was a problem hiding this comment.
This seems evil. Why are we hardcoding areas for specific countries?
I guess these countries are the ones that we can now calculate stuff for.
What happens whenever the client gets more data for additional countries? We will be using the values computed below. It does not seem right
There was a problem hiding this comment.
As I said I don't want to risk that due to the country area numbers are different, the only way is using the same harcoded numbers Elena has. Where did she got them? No idea as is not in the original excel. The other country areas are calculated using an equal area projection.
|
|
||
| def generate_sql_insert(rows: str) -> str: | ||
| return f""" | ||
| INSERT INTO public.countries |
There was a problem hiding this comment.
I thought we were using UPSERT?
Is it safe to only update the area (hardcoded or precomputed) and the geom:
There was a problem hiding this comment.
As far as I know an upsert in Postgres is resolve as an insert on conflict statement.
|
|
||
|
|
||
| # 5. Write SQL to a file | ||
| def write_sql_file(merged_gdf, output_file): | ||
| def write_sql_file(merged_gdf: gpd.GeoDataFrame, output_file: str) -> None: |
There was a problem hiding this comment.
Where is this file being saved? Can't see any path reference so I assume it is writing it in the current path
However the new file is under /data/excel. Is this the correct location?
There was a problem hiding this comment.
the sql statement is, the csv in in the raw_data/gadm folder.
|
let me know if the explanations are enough |
please review the generated files, so now i create a csv with hex wkb and the sql upsert statements