[MIRROR] [MIRROR] Signals and God #2865
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: CHOMPStation2/CHOMPStation2#11242
Original PR: VOREStation/VOREStation#18031
About The Pull Request
Makes a lot of things shoot out signals for stuff to listen out in the world.
Converted godmode from a flag to an element. Godmode now works on a lot more stuff. Due to things sending signals now, being an element allows it to listen into those signals.
Damage now INSTANTLY updates
Godmode now:
Stops you from having any status effect (stun, blurry eyed, embedded objects, among other stuff from happening to you.)
For robots, robots will no longer be EMP'd to death if they have godmode.
It works and I can't find anything wrong with it gameplay wise. Codewise it just mostly replaces the flag and makes an element that listens in to signals.
A few things I just replaced the godmode check with a godmode signal because I wasn't sure WHAT signal you'd even assign them.
Changelog
🆑 Diana
qol: Damage now updates immediately, instead of waiting for the next life tick.
code: Godmode works better now
/:cl: