Spec ref-counted producers #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domfarolino
force-pushed
the
spec-refcounted-producers
branch
from
4f4b4ab to
9a61a87
Compare
domfarolino
force-pushed
the
spec-refcounted-producers
branch
from
9a61a87 to
a46bb3e
Compare
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 14, 2025
This CL implements ref-counted producers, which came out of the W3C TPAC discussions in 2024. After this CL, multiple `ObservableInternalObserver` objects can be associated/registered with a single active `Subscriber`. The main meat of this CL involves the logic managing consumer unsubscription, to ensure that only once *all* associated consumers/observers unsubscribe do we actually close down a `Subscriber`. See WICG/observable#197. R=masonf Bug: 363015168 Change-Id: I67b63a3f4e38bf5be0236fd1b8f025648a3089bf
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Feb 14, 2025
This CL implements ref-counted producers, which came out of the W3C TPAC discussions in 2024. After this CL, multiple `ObservableInternalObserver` objects can be associated/registered with a single active `Subscriber`. The main meat of this CL involves the logic managing consumer unsubscription, to ensure that only once *all* associated consumers/observers unsubscribe do we actually close down a `Subscriber`. See WICG/observable#197. R=masonf Bug: 363015168 Change-Id: I67b63a3f4e38bf5be0236fd1b8f025648a3089bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6221901 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/main@{#1420647}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 14, 2025
This CL implements ref-counted producers, which came out of the W3C TPAC discussions in 2024. After this CL, multiple `ObservableInternalObserver` objects can be associated/registered with a single active `Subscriber`. The main meat of this CL involves the logic managing consumer unsubscription, to ensure that only once *all* associated consumers/observers unsubscribe do we actually close down a `Subscriber`. See WICG/observable#197. R=masonf Bug: 363015168 Change-Id: I67b63a3f4e38bf5be0236fd1b8f025648a3089bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6221901 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/main@{#1420647}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 14, 2025
This CL implements ref-counted producers, which came out of the W3C TPAC discussions in 2024. After this CL, multiple `ObservableInternalObserver` objects can be associated/registered with a single active `Subscriber`. The main meat of this CL involves the logic managing consumer unsubscription, to ensure that only once *all* associated consumers/observers unsubscribe do we actually close down a `Subscriber`. See WICG/observable#197. R=masonf Bug: 363015168 Change-Id: I67b63a3f4e38bf5be0236fd1b8f025648a3089bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6221901 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/main@{#1420647}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 18, 2025
…oducer, a=testonly Automatic update from web-platform-tests DOM: Implement ref-counted Observable producer This CL implements ref-counted producers, which came out of the W3C TPAC discussions in 2024. After this CL, multiple `ObservableInternalObserver` objects can be associated/registered with a single active `Subscriber`. The main meat of this CL involves the logic managing consumer unsubscription, to ensure that only once *all* associated consumers/observers unsubscribe do we actually close down a `Subscriber`. See WICG/observable#197. R=masonf Bug: 363015168 Change-Id: I67b63a3f4e38bf5be0236fd1b8f025648a3089bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6221901 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/main@{#1420647} -- wpt-commits: 976ac8e83a9197bf3153d902435aea5620da8df6 wpt-pr: 50723
benlesh
approved these changes
Feb 18, 2025
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Feb 19, 2025
…oducer, a=testonly Automatic update from web-platform-tests DOM: Implement ref-counted Observable producer This CL implements ref-counted producers, which came out of the W3C TPAC discussions in 2024. After this CL, multiple `ObservableInternalObserver` objects can be associated/registered with a single active `Subscriber`. The main meat of this CL involves the logic managing consumer unsubscription, to ensure that only once *all* associated consumers/observers unsubscribe do we actually close down a `Subscriber`. See WICG/observable#197. R=masonf Bug: 363015168 Change-Id: I67b63a3f4e38bf5be0236fd1b8f025648a3089bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6221901 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/main@{#1420647} -- wpt-commits: 976ac8e83a9197bf3153d902435aea5620da8df6 wpt-pr: 50723
github-actions bot
added a commit
that referenced
this pull request
Feb 21, 2025
SHA: a091c5a Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Feb 21, 2025
This CL puts the ref-counted producer implementation of Observables in sync with the latest spec changes, as per discussion in WICG/observable#197 (comment). Essentially, the Observable should not own its most recent active Subscriber, and a Subscriber kept alive by JavaScript should not keep its associated Observable alive if it is no longer referenced by script. This CL ensures these garbage collection semantics are tested too. R=masonf Bug: 40282760 Change-Id: I6579f5a5c95557f686d078c0aef7094b8e216066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6287812 Commit-Queue: Dominic Farolino <[email protected]> Reviewed-by: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1423285}
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Feb 25, 2025
…oducer, a=testonly Automatic update from web-platform-tests DOM: Implement ref-counted Observable producer This CL implements ref-counted producers, which came out of the W3C TPAC discussions in 2024. After this CL, multiple `ObservableInternalObserver` objects can be associated/registered with a single active `Subscriber`. The main meat of this CL involves the logic managing consumer unsubscription, to ensure that only once *all* associated consumers/observers unsubscribe do we actually close down a `Subscriber`. See WICG/observable#197. R=masonf Bug: 363015168 Change-Id: I67b63a3f4e38bf5be0236fd1b8f025648a3089bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6221901 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/main@{#1420647} -- wpt-commits: 976ac8e83a9197bf3153d902435aea5620da8df6 wpt-pr: 50723
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #170. Closes #178.
Corresponding Chromium change and tests: https://chromium-review.googlesource.com/c/chromium/src/+/6221901.
Preview | Diff