Skip to content

Editorial: Clean up spec markdown #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

shaseley
Copy link
Collaborator

@shaseley shaseley commented Jul 24, 2023

  • Use column width 100 (previously 80)
  • Reorganize sections to not mix algorithms and data
  • Factor out TaskSignal.any() algorithm
  • Remove unnecessary "perform the following steps:" at the end of algorithm definitions
  • Remove link tag conjugations that bikeshed can handle
  • Use consistent heading syntax

Preview | Diff

@shaseley shaseley force-pushed the controlling-tasks-cleanup branch from 08544bc to 16bccb7 Compare April 3, 2024 23:50
@shaseley shaseley changed the title Editorial: Clean up controlling tasks section of the spec Editorial: Clean up spec markdown Apr 3, 2024
@shaseley shaseley requested a review from clelland April 4, 2024 00:01
@shaseley
Copy link
Collaborator Author

shaseley commented Apr 4, 2024

He @clelland, would you mind reviewing this? I want to clean this up a bit before adding more. This is mostly mechanical -- see prpreview in first comment for diffs. Thanks!

Copy link
Collaborator

@clelland clelland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mechanical changes here all look good, as does the separation of the algorithm from the any() method steps.

@shaseley
Copy link
Collaborator Author

shaseley commented Apr 4, 2024

Thanks Ian!

@shaseley shaseley merged commit 27cd411 into WICG:main Apr 4, 2024
2 checks passed
@shaseley shaseley deleted the controlling-tasks-cleanup branch April 4, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants