Skip to content

Editorial: Parameterize TaskSignal.any() realm and fix linking #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2024
Merged

Editorial: Parameterize TaskSignal.any() realm and fix linking #85

merged 1 commit into from
Apr 9, 2024

Conversation

shaseley
Copy link
Collaborator

@shaseley shaseley commented Apr 5, 2024 •
edited by pr-preview bot
Loading

@shaseley shaseley requested a review from clelland April 5, 2024 23:55
@shaseley
Copy link
Collaborator Author

shaseley commented Apr 5, 2024

I noticed the linking was broken while drafting yield(), and also will need to pass a realm here to create a dependent signal w/o JS on the stack, so figured I'd break this off.

@clelland , mind reviewing? Thanks!

@shaseley
Copy link
Collaborator Author

shaseley commented Apr 9, 2024

Thanks @mmocny.

@shaseley shaseley merged commit d1bf8ab into WICG:main Apr 9, 2024
2 checks passed
@shaseley shaseley deleted the task-signal-any-realm branch April 9, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmocny mmocny mmocny approved these changes

@clelland clelland Awaiting requested review from clelland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaseley @mmocny