Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wisdem api #183

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Fix wisdem api #183

wants to merge 6 commits into from

Conversation

gbarter
Copy link
Member

@gbarter gbarter commented Nov 7, 2024

The WISDEM API became out of sync with the changes in the recent ORBIT release, which was flagged by users. To do a better job catching this next time, I wonder if:

  • Maybe this WISDEM API file is owned by the WISDEM repository. That would aid in us just using ORBIT as a library
  • There was a schema that checked the config-dictionary and provided warnings for unused entries. What do you think?

@gbarter gbarter requested a review from nRiccobo November 7, 2024 00:47
@nRiccobo
Copy link
Collaborator

nRiccobo commented Nov 7, 2024

Thanks for putting this together. I think there is definitely room to ensure WISDEM and ORBIT interface nicely. Especially through code updates. This api file always slips my mind as new ORBIT changes come through.

I'm open to either way at this point. We're working on a few more cost/project parameter updates - so we might have to repeat these steps. But, I'll review this and get it into dev so users can continue their work.

@gbarter
Copy link
Member Author

gbarter commented Nov 7, 2024

Thanks for putting this together. I think there is definitely room to ensure WISDEM and ORBIT interface nicely. Especially through code updates. This api file always slips my mind as new ORBIT changes come through.

I'm open to either way at this point. We're working on a few more cost/project parameter updates - so we might have to repeat these steps. But, I'll review this and get it into dev so users can continue their work.

Thank you, Nick! On the last point, all the more reason to have some sort of "echo" of which config parameters are understood versus not. That way old analysis scripts or code get feedback when parameter values are not being passed through.

@nRiccobo
Copy link
Collaborator

nRiccobo commented Nov 12, 2024

I adjusted some of the variable names to be consistent with ORBIT's latest project_parameters. In future releases, some of these parameters (a.k.a soft costs) will be calculated based on the project size and type, rather than user-defined. However, ORBIT is still backwards compatible (for the most part) and allows the user to define USD/kW values for these parameters. For simplicity, I went this route and defined the default values as $/kW based on a 600MW (50 x 12MW) plant.

Copy link
Collaborator

@nRiccobo nRiccobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this up!

@gbarter
Copy link
Member Author

gbarter commented Nov 12, 2024

I adjusted some of the variable names to be consistent with ORBIT's latest project_parameters. In future releases, some of these parameters (a.k.a soft costs) will be calculated based on the project size and type, rather than user-defined. However, ORBIT is still backwards compatible (for the most part) and allows the user to define USD/kW values for these parameters. For simplicity, I went this route and defined the default values as $/kW based on a 600MW (50 x 12MW) plant.

It would probably be easier for WISDEM to use the internal ORBIT calculation for many of these line entries, as that would better scale with design changes coming from WISDEM. Feel free to delete those parameters that have internal ORBIT calculations that are recommended best practice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants