-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wisdem api #183
base: dev
Are you sure you want to change the base?
Fix wisdem api #183
Conversation
Thanks for putting this together. I think there is definitely room to ensure WISDEM and ORBIT interface nicely. Especially through code updates. This api file always slips my mind as new ORBIT changes come through. I'm open to either way at this point. We're working on a few more cost/project parameter updates - so we might have to repeat these steps. But, I'll review this and get it into dev so users can continue their work. |
Thank you, Nick! On the last point, all the more reason to have some sort of "echo" of which config parameters are understood versus not. That way old analysis scripts or code get feedback when parameter values are not being passed through. |
…puts. Also updated examples that had outdated inputs.
… but var names don't have _per_kW.
I adjusted some of the variable names to be consistent with ORBIT's latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing this up!
It would probably be easier for WISDEM to use the internal ORBIT calculation for many of these line entries, as that would better scale with design changes coming from WISDEM. Feel free to delete those parameters that have internal ORBIT calculations that are recommended best practice |
The WISDEM API became out of sync with the changes in the recent ORBIT release, which was flagged by users. To do a better job catching this next time, I wonder if: