Fix: PHP 8.2+ dynamic property deprecations in WPUM_Field#435
Merged
polevaultweb merged 3 commits intodevelopfrom Mar 14, 2026
Merged
Fix: PHP 8.2+ dynamic property deprecations in WPUM_Field#435polevaultweb merged 3 commits intodevelopfrom
polevaultweb merged 3 commits intodevelopfrom
Conversation
…8.2+ dynamic property deprecations
…eld object pass-through
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #434
Problem
Sites upgraded from older WPUM versions may still have legacy columns in their
wpum_fieldstable (is_required,show_on_registration,can_delete,default_visibility,allow_custom_visibility,options,meta) left over from before field configuration was migrated towpum_fieldmeta.dbDelta()never drops columns, so they persist indefinitely.WPUM_DB::get()usesSELECT *, which returns all columns including these orphaned ones.setup_field()then assigned every returned property directly to$this, creating dynamic properties that PHP 8.2+ deprecates.Fix
Filter the loop in
setup_field()to only assign columns that are part of the declared schema (get_columns()). Orphaned legacy columns are silently ignored — no database migration needed.Testing
On a site with legacy
wpum_fieldscolumns, the deprecation notices atclass-wpum-field.php:214should no longer appear on PHP 8.2+.