Fix doAuthenticatedRequest when response has no body (#2)

* Fix doAuthenticatedRequest when response has no body
WakeOnWeb · Feb 19, 2018 · 1015436 · 1015436
1 parent ca5c474
commit 1015436
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/REST/Client.php b/src/REST/Client.php
@@ -161,7 +161,14 @@ private function doAuthenticatedRequest(Request $request)
             throw new SalesforceClientException($e->getMessage(), 0, $e);
         }
 
-        return json_decode((string) $response->getBody(), true);
+        $body = '[]';
+
+        // Check if response has content
+        if ($response->getStatusCode() !== 204) {
+            $body = (string) $response->getBody();
+        }
+
+        return json_decode($body, true);
     }
 
     private function connectIfAccessTokenIsEmpty()

diff --git a/tests/REST/ClientTest.php b/tests/REST/ClientTest.php
@@ -89,7 +89,7 @@ public function test_create_object()
 
     public function test_patch_object()
     {
-        $sut = $this->createSUT(null, new Response(200));
+        $sut = $this->createSUT(null, new Response(204));
         // we can't test the request since stream are different ...
         // let's find a way to fix that.
         $this->assertNull($sut->patchObject('foo', 1234, []));