Skip to content

added HQ svg #4227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Chewbakka-Wakka
Copy link

As per #1789

With this SVG in use we can drop the package "hicolor-icon-theme" from all Linux builds (when updated) from OS requires. The SVG can be used instead of one of the various fixed png loaded files for desktop icon.

@past-due
Copy link
Member

past-due commented Mar 8, 2025

A couple of questions / concerns:

  • This SVG file isn’t actually a vector SVG - it appears to just be an SVG container that embeds the PNG file directly. How is this superior or different from us installing the PNG?
  • The only place that we reference the “hicolor-icon-theme”, that I can see, is in the Flatpak’s install location of an icon .png - and IIRC that’s recommended for Flatpaks. (The Flatpak uses the Freedesktop Runtime, and hicolor is the default fallback theme by the spec: https://askubuntu.com/a/300155)

Implementations are required to look in the "hicolor" theme if an icon was not found in the current theme.

@Chewbakka-Wakka
Copy link
Author

Thanks for finding my mistake, you are correct.
I'll get this fixed to be a vector SVG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants