Skip to content

Conversation

cswni
Copy link
Contributor

@cswni cswni commented Nov 5, 2024

  • This pull request includes several changes to the user profile components and views, focusing on improving the user interface and handling errors more effectively. The most important changes include modifications to error handling, user interface adjustments, and the introduction of a new hook for authentication.

Error Handling Improvements:

User Interface Adjustments:

Authentication Hook Integration:

cswni added 3 commits November 5, 2024 12:44
Adjusted the profile bio section to ensure a minimum width. Updated the icon used for the share button to be more specific. Changed the profile update button from contained to outlined variant for better visual consistency.
Ensure that error messages are logged appropriately to aid in debugging. This change:
- Adds error.message logging with TypeScript ignore comments.
- Updates setErrorMessage to provide a default error message.
Updated user-profile-view to use the useAuth hook for better state management and clean up the useLazyProfile hook usage.
- Imported useAuth hook to manage selectedProfile state.
- Removed redundant data fetching from useLazyProfile hook.
@cswni cswni added the Refactor label Nov 5, 2024
@cswni cswni requested review from Jadapema and geolffreym November 5, 2024 18:48
@cswni cswni self-assigned this Nov 5, 2024
Copy link

sonarqubecloud bot commented Nov 5, 2024

@cswni cswni added the in progress Work in progress label Nov 5, 2024
Copy link
Member

@Jadapema Jadapema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jadapema Jadapema merged commit 72a158c into v2/mvp_redesign Nov 5, 2024
3 checks passed
@cswni cswni added Done Task completed and removed in progress Work in progress labels Nov 5, 2024
@cswni cswni deleted the v2/fix/profile-update branch March 6, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Done Task completed Refactor

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

feat: verify that after updating the metadata in the profile they are not refreshed in real time

2 participants