Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle responsive capabilities #245

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

cswni
Copy link
Contributor

@cswni cswni commented Nov 5, 2024

This pull request introduces a new ResponsiveOverlay component and integrates it into the application. The most important changes include the creation of the ResponsiveOverlay component, its export, and the necessary adjustments to the configuration files to support new imports.

New Component Addition:

Integration:

  • src/App.tsx: Imported and integrated the ResponsiveOverlay component into the main application component. [1] [2]

Configuration Updates:

  • tsconfig.app.json: Added a new path alias for the public directory to support the new image import in the ResponsiveOverlay component.
  • vite.config.ts: Added a new alias for the public directory to facilitate the import of assets.

image

cswni added 2 commits November 5, 2024 13:29
- Integrated a new `ResponsiveOverlay` component:
  - Displays an overlay on small screens, indicating ongoing responsive work.
  - Triggers based on screen width, using a resize listener.
- Added the responsive image asset:
  - Included `working-responsive.png` to be displayed in the overlay.
- Adjusted `App.tsx`:
  - Incorporated the `ResponsiveOverlay` component into the main application component tree.
- Updated tsconfig.app.json to include '@public/*' path alias pointing to './public/*'.
- Modified vite.config.ts to resolve '@public' to 'public' directory.
- This change improves file organizing by centralizing public assets access.
@cswni cswni added in progress Work in progress UI labels Nov 5, 2024
@cswni cswni requested review from geolffreym and Jadapema November 5, 2024 19:32
@cswni cswni self-assigned this Nov 5, 2024
Copy link

sonarqubecloud bot commented Nov 5, 2024

Copy link
Member

@Jadapema Jadapema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jadapema Jadapema merged commit a2a6089 into v2/mvp_redesign Nov 5, 2024
3 checks passed
@cswni cswni added Done Task completed and removed in progress Work in progress labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Done Task completed UI
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

feat: Put a blankslate when it is less than x saying that the responsive is still being worked on
2 participants