Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: explore view #250

Closed
wants to merge 261 commits into from
Closed

refactor: explore view #250

wants to merge 261 commits into from

Conversation

cswni
Copy link
Contributor

@cswni cswni commented Nov 11, 2024

This pull request introduces several new carousel components and updates existing ones in the src/components/carousel/variants directory. It also includes changes to the poster-horizontal component and updates to the explore view.

New Carousel Components:

Updates to Existing Components:

General Improvements:

  • use-carousel.ts: Added a @ts-ignore comment to ignore TypeScript errors in the beforeChange function.
  • explore/view.tsx: Added new imports and updated the explore view to include new carousel components for trending topics and top titles.

These changes enhance the carousel functionality and improve the user interface for displaying posters and trending topics.

@cswni cswni requested review from geolffreym and Jadapema November 11, 2024 21:39
@cswni cswni self-assigned this Nov 11, 2024
@cswni cswni linked an issue Nov 11, 2024 that may be closed by this pull request
- Added icons from @tabler/icons-react to navigation items.
- Updated titles to "ListenIt," "CaptureIt," "ReadIt," "StoreIt," and "PlayIt."
- Added "Coming Soon" badges and assigned distinct background colors for better user experience.
- Removed unnecessary padding in `carousel-top-titles.tsx` to improve UI consistency.
- Refactored `poster-top-titles.tsx` by removing unused props and simplifying the layout for better readability.
- Adjusted Button styling and removed redundant typography elements to streamline the design.
- Updated `poster-horizontal.tsx` to exclude irrelevant data (year, genre) and enhance its focused content.
- Cleaned up `view.tsx` by removing unused Tabs components to simplify the exploratory section.
cswni and others added 23 commits November 12, 2024 16:43
- Removed inline height style from `carousel-top-titles` component to improve design consistency.
- Added new icon `IconRosetteDiscountCheckFilled` for author verification in `poster-top-titles`.
- Modified JSX structure and styles in `poster-top-titles` to center images and display author information.
- Updated `explore` section to change titles in the content list.
- Introduced a state `sidebarWidth` to control the sidebar width.
- Added toggle functionality for collapsing and expanding the sidebar.
- Integrated new icons to visually indicate sidebar state.
- Modified `NavSectionVertical` to adapt subheader display based on sidebar state.
- Applied smooth transition styles for sidebar and main component layout changes.
- Introduce state for managing sidebar width in DashboardLayout.
- Add interactive button to toggle sidebar width between mini and vertical.
- Update NavVertical component to accept and utilize the new sidebarWidth prop.
- Change the "start" script to run Vite with "--host 0.0.0.0".
- Allows access to the development server from external devices.
- Facilitates testing on different local network devices.
# Conflicts:
#	src/pages/dashboard/studio.tsx
Refactored the dashboard layout to include a mini navigation option, and optimized sidebar logic.

- Introduced a mini navigation layout supported by new components: `NavVerticalMini`, `NavListVerticalMini`, and `NavItemVerticalMini`.
- Removed unnecessary state management for sidebar width and toggle functionality.
- Adjusted layout styling and positioning to accommodate the new mini navigation.
- Updated the header to work seamlessly with both full and mini navigation layouts.
- Enhanced language popover and navigation toggle button to integrate with mini layout settings.
- Remove `nav` prop handlers from `NavVerticalMini` in layout.
- Adjust button and typography styles in searchbar for better responsiveness.
- Comment out `ResponsiveOverlay` in `App.tsx`.
- Add `Searchbar` component to dashboard header.
- Remove `Searchbar` from `nav-vertical`.
- Poster layout now adjusts direction and max width based on screen size
- Carousel settings modified for consistent slide display across breakpoints
- Dashboard header cleaned up by removing redundant styles for horizontal navigation
- Adjusted margins and padding for sections to enhance mobile view
- Increased width dimensions for vertical navigation mini layout
- Updated dashboard community page title to 'WatchIt | Community' for clearer identification
# Conflicts:
#	src/layouts/dashboard/header.tsx
Improve code comments for better understanding and maintainability:
- Clarified the purpose of importing the Image component.
- Added a comment for the Projects section in dashboard layout.
- Introduced a new constant `TOGGLE_TOP` to manage the top offset.
- Updated `nav-toggle-button.tsx` to use the new `TOGGLE_TOP` constant for positioning.
- Integrate settings context and responsiveness into Searchbar.
- Modify Toolbar in header for improved styling and layout.
- Add Searchbar to vertical and mini navigation components.
- Adjust color scheme and active styles for nav-section in mini mode.
- Removed console log from searchbar.tsx and added conditional rendering for labels.
- Adjusted TOGGLE_TOP and padding in config-layout.ts.
- Integrated config-layout constants into main.tsx and added padding.
- Introduced sx prop for spacing in header.tsx and modified width calculation.
- Changed background color and positioning styles in nav-vertical-mini.tsx.
geolffreym and others added 28 commits December 4, 2024 12:07
Introduce the `useResponsive` hook to adjust layouts according to screen size. Adjust profile card width to span full width on smaller screens and maintain dual-column layout on larger screens. Enhance scrolling behavior by combining `overflowY` and `overflow` properties for better responsiveness.
Add `TextMaxLine` component for improved text handling and adjust `Box` style properties for better layout adaptability across different screen sizes. Introduced dynamic spacing and positioning based on screen breakpoints to enhance user experience, ensuring the interface is more intuitive and accessible on both mobile and desktop devices. Updated `overflow` and `zIndex` properties to resolve potential layout issues.
- **loginModal/modal.tsx**: Added `style` with `overflow: 'scroll'` and set `disableScrollLock` to `true` to allow content scrolling and prevent scroll blocking.
- **updateModal/modal.tsx**: Implemented the same scrolling adjustments to enhance user interface consistency across modal components.
Enhance the ExploreView component by dynamically adjusting the item width of the CarouselPosterMini based on screen size using the useResponsive hook.

- **view.tsx**:
  - Imported `useResponsive` hook.
  - Added logic to set `minItemWidth` and `maxItemWidth` differently when viewing on large screens versus smaller ones.
  - Updated `CarouselPosterMini` to use the new adaptive item width values.
- src/sections/user/profile-header.tsx:
  - Append unique identifiers to keys in social, share, and partner links.
  - Add specific keys for Snackbar components to prevent remounting issues.
- src/sections/user/view/user-profile-view.tsx:
  - Include a unique key for Tabs based on profile ID for better rendering.
- src/components/loginModal/profileFormView.tsx:
  - Convert username input to lowercase before setting the field value, ensuring consistent casing.
- Replace Typography with TextMaxLine for likes display, ensuring it handles undefined likes gracefully by defaulting to 0.
- Adjust line clamping behavior for improved visual consistency.
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots
3.4% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@geolffreym geolffreym closed this Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
3 participants