-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: session issues and minor fixes (converge branches) #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: bundler client null and session data anonymous
- Refactored `profile-header.tsx` to simplify and modularize components. - Added `ProfileReport` to handle report functionality for authenticated users. - Added `ProfileRightSidebar` for displaying profile-related sidebar content. - Integrated `ProfileToolbar` for toolbar functionalities such as share options. - Added `ProfileUserInfo` for structured user information display. - Introduced `ProfileJoin` for manage joining features (subscription or follow). This modularization simplifies `ProfileHeader`, reduces complexity, and makes it easier to maintain.
- Updated `Invitation` import path in `profile-referrals-table-row.tsx` and `profile-referrals.tsx` to use a type-specific module. - Moved the `status` cell content in `profile-referrals-table-row.tsx` from a separate `TableCell` to inside the conditional rendering within the `profile` column. - Simplified the `TABLE_HEAD` in `profile-referrals.tsx` by removing the redundant `profile` column definition.
fix: minor issues
|
Jadapema
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to various components and hooks, focusing on improving user authentication checks, code cleanup, and adding new features. The most important changes include adding authentication checks, removing redundant code, and introducing new components for user interactions.
Authentication and Access Control Enhancements:
src/components/publication-detail-main.tsx
: Added a check forsessionData?.authenticated
to ensure the user is authenticated before displaying certain components.src/hooks/use-account-session.ts
: Updated the hook to bypass certain checks if the user is authenticated or has an anonymous session.Code Cleanup and Simplification:
src/hooks/use-web3-session.ts
: Removed unnecessaryuseMemo
hooks and simplified the assignment ofaccountAbstractionProvider
properties.src/components/subscribe-to-unlock-card.tsx
: Commented out thedisabled
property for the subscribe button to simplify the code.New Components and Features:
src/sections/user/profile-join.tsx
: Introduced a newProfileJoin
component that handles user subscription logic and displays a modal for subscribing to a profile.src/sections/user/profile-report.tsx
: Added a newProfileReport
component that allows users to report profiles through a modal.src/sections/user/profile-right-sidebar.tsx
: Created aProfileRightSidebar
component to display profile-related information and actions, including license details and distribution partners.