test(core): add finance tests and refactor existing tests to support new API #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
May 5, 2025 11:27
…dability and add missing test for connect button
…n and session handling
…romStripe component
… function and enhance readability
…ngSoonIllustration component
…le missing session data
… smart account deposit
- Adjusted mocks for GetAllPosts query to use the new API. - Updated test setup to reflect changes in the component and API responses. - Ensured compatibility with new API and existing logic for loading state and screen size handling.
…rify public sections rendering
…dability and add missing test for connect button
…n and session handling
added 9 commits
May 19, 2025 10:07
… likeCount assertions
…nhance snapshot accuracy
…ing and post rendering logic
This was
linked to
issues
May 23, 2025
|
There was a problem hiding this comment.
Pull Request Overview
Adds and refactors unit tests for finance components and updates existing explore section tests to support the new custom API.
- Introduces new Vitest tests for finance components under
src/sections/finance/components/__test__ - Refactors explore views and components tests, replacing Lens protocol mocks with Apollo
MockedProviderand updateduseAuth/useSelectormocks - Updates numerous snapshots to reflect UI and API changes
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/sections/finance/components/test/finance-deposit-from-metamask.test.tsx | New tests for Metamask deposit flow |
| src/sections/finance/components/test/finance-box-row.test.tsx | New layout tests for box row component |
| src/sections/finance/components/test/snapshots/finance-display-profile-info.test.tsx.snap | Added snapshot for profile info component |
| src/sections/explore/components/test/explore-bookmarks.test.tsx | Refactored bookmarks tests with Apollo mocks |
| src/sections/explore/components/test/explore-top-publications.test.tsx | Updated top publications tests to await rendered data and use screen API |
Comments suppressed due to low confidence (1)
src/sections/explore/components/test/explore-bookmarks.test.tsx:3
- [nitpick] The import path for
storeis inconsistent ("@redux/store.ts") compared to other files ("@src/redux/store"). Align the path for clarity.
import { store } from "@redux/store.ts";
src/sections/finance/components/__test__/finance-deposit-from-metamask.test.tsx
Show resolved
Hide resolved
src/sections/finance/components/__test__/__snapshots__/finance-box-row.test.tsx.snap
Show resolved
Hide resolved
...ections/finance/components/__test__/__snapshots__/finance-display-profile-info.test.tsx.snap
Show resolved
Hide resolved
src/sections/explore/components/__test__/explore-top-publications.test.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces partial unit test coverage for components and views within the src/sections/finance directory.
Unit Tests Added:
Components:
Additional Notes:
Since we migrated from the Lens protocol to a custom API developed by the team, some of the existing tests had to be updated to reflect those changes and keep everything working smoothly.
There are still a few components and flows that don’t have full test coverage yet. We plan to address those in upcoming pull requests to make sure this section is well covered.