Skip to content

Provide "natural scrolling" option for mice. #2370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

mgriego
Copy link
Contributor

@mgriego mgriego commented May 27, 2024

Many mice support natural/reversed scrolling through libinput these days. This enables mouse natural scrolling throug a separate config option specifically for mice.

@ammen99
Copy link
Member

ammen99 commented May 28, 2024

Thanks for the PR, I am however thinking whether it wouldn't be much simpler to simply allow negative mouse scroll speed, as we already have an option for that?

@mgriego mgriego marked this pull request as ready for review May 29, 2024 03:23
@mgriego
Copy link
Contributor Author

mgriego commented May 29, 2024

I would argue that using the natural scrolling option is more inline with what other graphical systems offer as an option and inline with what is expected for libinput.

@marcusbritanicus
Copy link
Contributor

Purely from a user point of view, especially for those migrating from other places (kde/gnome/.../mac/win), it would be nice if we have that check box. But I do not have any opinion on how it's implemented, though.

I do have a small nitpick in the xml file: Instead of <_short>Mouse natural scroll</_short>, it would be preferable to use <_short>Natural scroll</_short>, just as in touch pad configuration. In wcm, this option will appear in the "Mouse" tab, so it will not cause any confusion to the users.

@mgriego
Copy link
Contributor Author

mgriego commented May 29, 2024

@marcusbritanicus The scroll speed and cursor speed options are both prefixed with Mouse... ie: https://github.com/WayfireWM/wayfire/blob/master/metadata/input.xml#L226 . To me, this feels similar: it's a shared option that is scoped to mouse vs trackpad.

To be clear, I'm not opposed to that line of thinking. It makes sense that it would be scoped by the mouse vs trackpad input group, so having the config prefix is a bit redundant. My comment is more about consistency.

@mgriego
Copy link
Contributor Author

mgriego commented Jun 6, 2024

@ammen99 Any other concerns here?

Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ammen99 ammen99 merged commit 8251334 into WayfireWM:master Jun 18, 2024
4 checks passed
@mgriego mgriego deleted the mouse-natural-scrolling branch June 19, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants