Set initial decoration mode properly#2401
Closed
wb9688 wants to merge 1 commit intoWayfireWM:masterfrom
Closed
Conversation
Member
|
I think the real problem is that the following happens:
So the proper fix would be to have the old code (which just sets the decoration status without calling the function which also emits the decoration updated signal) in start_map_tx. Would you mind trying this out to see whether it works? Because with this patch, the flow of events is like this (and I think it is suboptimal):
|
Member
|
Closing as this seems pretty stale and also the wrong approach as outlined in my previous comment. Feel free to submit another PR with the updated approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets the initial decoration mode properly for clients that announce the
wl_surfacewith the decoration protocol before the xdg-surface view, such as GTK 4, so that they are properly decorated.