only bring toplevels to front #2716
Open
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't bring a popup or subsurface to front as subsurfaces have their own order. fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1943240. fixes WayfireWM#2566.
lilydjwg
force-pushed
the
subsurface-order
branch
from
2e95a94 to
e6ad62e
Compare
|
The fix is weird because what you describe is a bug related to subsurface ordering, and the patch that you have will make a difference only if we have dialogs. Can you explain how to reproduce the issue starting from a fresh install of firefox? |
|
I have written steps to reproduce in the firefox bug. Copying it here:
|
test.mp4 |
I repeated these steps but it works OK here. Firefox 139.0.4 |
are you on matrix wayfire chat? https://matrix.to/#/#wayfire:matrix.org |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't bring a popup or subsurface to front as subsurfaces have their own order.
fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1943240. fixes #2566.