only bring toplevels to front

[lilydjwg]

Don't bring a popup or subsurface to front as subsurfaces have their own order.

fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1943240. fixes #2566.

[ammen99]

The fix is weird because what you describe is a bug related to subsurface ordering, and the patch that you have will make a difference only if we have dialogs. Can you explain how to reproduce the issue starting from a fresh install of firefox?

[lilydjwg]

I have written steps to reproduce in the firefox bug. Copying it here:

• Create a folder in the bookmark bar
• Create a folder inside the folder just created
• Right click on the new folder to open a context menu

[killown]

test.mp4

[ammen99]

I have written steps to reproduce in the firefox bug. Copying it here:

• Create a folder in the bookmark bar
• Create a folder inside the folder just created
• Right click on the new folder to open a context menu

I repeated these steps but it works OK here. Firefox 139.0.4

[killown]

I have written steps to reproduce in the firefox bug. Copying it here:

* Create a folder in the bookmark bar

* Create a folder inside the folder just created

* Right click on the new folder to open a context menu

are you on matrix wayfire chat? https://matrix.to/#/#wayfire:matrix.org

[killown]

could you use ammen patch in your pr https://0x0.st/8GY3.diff

[lilydjwg]

Updated. It feels a bit weird that I'm asking to merge a commit authored by ammen to ammen's project.

[ammen99]

Updated. It feels a bit weird that I'm asking to merge a commit authored by ammen to ammen's project.

It is also important to test the changes :)

I am considering whether we could easily develop an automatic test for this. I find them very useful to catch such corner cases. Things break more often than one might think.

[ammen99]

Added a test here: ammen99/wayfire-tests@5a92147

Should prevent us from getting it wrong again :)