Skip to content

fix: 1.9 reveal private credentials ui #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

ieow
Copy link

@ieow ieow commented May 24, 2025

Description

1.9
Update New SRP onboarding flow as per figma design
https://www.figma.com/design/pViOUcmjwhEzFsdrwknpNc/Onboarding-redesign?node-id=434-55200&t=wmEoQSF9g9lFtkwp-0

This PR is part 9 of 9 for the new SRP ui update

This PR cover

  • Fix reveal Private Credential

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Screen.Recording.2025-05-24.at.5.26.16.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ieow ieow force-pushed the fix/reveal-private-cred branch from 3139634 to 8de137c Compare May 24, 2025 08:18
@ieow ieow changed the title fix: reveal private credentials ui fix: 1.8 reveal private credentials ui May 24, 2025
@ieow ieow mentioned this pull request May 24, 2025
7 tasks
@ieow ieow changed the title fix: 1.8 reveal private credentials ui fix: 1.9 reveal private credentials ui May 24, 2025
@ieow ieow force-pushed the fix/reveal-private-cred branch from 8de137c to de79624 Compare May 24, 2025 08:48
@ieow ieow mentioned this pull request May 24, 2025
7 tasks
@ieow
Copy link
Author

ieow commented May 26, 2025

This PR is closed in favour of pr https://github.com/MetaMask/metamask-mobile/pull/->15644

@ieow ieow closed this May 26, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant