Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor setTssTag #218

Merged
merged 1 commit into from
Feb 26, 2025
Merged

feat: refactor setTssTag #218

merged 1 commit into from
Feb 26, 2025

Conversation

ieow
Copy link
Contributor

@ieow ieow commented Feb 21, 2025 •
edited
Loading

Motivation and Context

Jira Link:

Description

using tkey/tkey#305 tkey tss lib instead

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

@ieow ieow marked this pull request as ready for review February 21, 2025 20:27
@matthiasgeihs matthiasgeihs self-requested a review February 25, 2025 20:38
matthiasgeihs
matthiasgeihs reviewed Feb 25, 2025
View reviewed changes
Copy link
Contributor

@matthiasgeihs matthiasgeihs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this can only be reviewed once new tkey version has been released

@ieow ieow merged commit 1892f5e into feat/refactor-v4-multicurve Feb 26, 2025
1 check failed
@ieow ieow deleted the feat/refactor-v2-multicurve-setTssTag branch February 26, 2025 17:00
@ieow
Copy link
Contributor Author

ieow commented Feb 26, 2025

merged to the pr #217 as tkey will be using the setTssTag branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasgeihs matthiasgeihs matthiasgeihs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ieow @matthiasgeihs