Refactor inline section into more general instruction frequencies #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change renames the `inlining` section to `instr_freq` and allows such frequencies for arbitrary instructions with the given frequencies applying to all following instructions. It also changes the convoluted logarithmic scheme to a more transparent log2 based scheme at an acceptable loss of resolution.
eqrion
approved these changes
Jun 10, 2025
| | 48| +16| 65536 | | ||
| | 56| +24| 1.678e+07| | ||
| | 64| +32| >4.295e+09| | ||
| | 127| |*always inline* | | ||
|
|
||
| If the *byte offset* is 0, the hint applies to all call sites where the function is the **target**. It serves as a shorthand notation unless explicitly overridden. In this case, the call frequency should be a rough estimate of the average call frequency of all potential sites. *Note: This should likely be moved to a dedicated section for clearer separation, e.g. `metadata.function.inline` if such a namespace will be supported by custom annotations.* |
There was a problem hiding this comment.
Does this part still make sense if we have moved to general instruction frequencies?
There was a problem hiding this comment.
Yeah, I'm not too happy about that part and I'd be in favor of dropping it unless tool chains insist on it.
Co-authored-by: Ryan Hunt <[email protected]>
in `instr_freq` section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change renames the
inlinesection toinstr_freqand allows such frequencies for arbitrary instructions with the given frequencies applying to all following instructions.It also changes the convoluted logarithmic scheme to a more transparent log2 based scheme at an acceptable loss of resolution.
This implements the changes requested in issue #8.